Skip to content

filemanager: GDP Move to Trash #240

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 2 commits into from

Conversation

Martin-Rehr
Copy link
Contributor

In the 'old' days project files were located in 'vgrid_files_home'. Now days files are located in 'vgrid_files_writable'. Take the latter into account when extracting the relative path for GDP 'move to trash' log.

@Martin-Rehr Martin-Rehr linked an issue May 5, 2025 that may be closed by this pull request
Copy link
Contributor

@jonasbardino jonasbardino left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks correct to me.
I think it would be good to add a simple comment for clarity that we replace both for old style and new style vgrid fs layouts.

@jonasbardino jonasbardino added the bug Something isn't working label May 7, 2025
@Martin-Rehr
Copy link
Contributor Author

Manually merged through svn

@Martin-Rehr Martin-Rehr closed this May 9, 2025
@Martin-Rehr Martin-Rehr deleted the fix/gdp-fileman-move-to-trash branch May 9, 2025 12:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

'Move to trash' resulting in Invalid GDP path ...
3 participants