Break the installation defaults out into their structure. #218
Conversation
Add tests that assert the consistency of the options that are accepted by the generateconfs command line with the internal library function. Additionally assert that the library routine itself matches the defaults structure thus making the _structure_ the definitive source of truth. Doing so highlighted the following missing command line options which are added as of this commit: --seafile_secret --seafile_ccnetid
| @@ -247,6 +247,8 @@ def main(argv, _generate_confs=generate_confs, _print=print): | |||
| 'openid_port', | |||
| 'openid_show_port', | |||
| 'openid_session_lifetime', | |||
| 'seafile_secret', | |||
There was a problem hiding this comment.
Hmm, I have a hunch that we on purpose did not expose this option to prevent passing secrets on the command line, where they may be leak to shell history and any other local users. There's a note about the similar case for the OIDCCryptoPassphrase in mig/install/apache-MiG-template.conf.
At least we need to discuss the security implications before allowing anything like that.
|
Let me know which keys should be hidden and I will make the change. |
|
Well, anything that indicates a secret, including password/passphrase needs closer consideration. Perhaps rule of thumb for a migrid developer's guide. |
Add tests that assert the consistency of the options that are accepted by the generateconfs command line with the internal library function. Additionally assert that the library routine itself matches the defaults structure thus making the structure the definitive source of truth.
Doing so highlighted the following missing command line options which are added as of this commit:
--seafile_secret
--seafile_ccnetid