Split the support library into separate files within a module directory. #114
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
albu-diku
force-pushed
the
refactor/split-up-test-support-library
branch
from
b4e2545 to
3c15f06
Compare
Closed
jonasbardino
added this to the
Python3 support for general research data sites milestone
jonasbardino
approved these changes
Aug 31, 2024
There was a problem hiding this comment.
Looks good - merging with minor changes to include missing doc strings and reformat a few oddly short comment lines to the default 80ish chars.
Personally I'd probably have ripped out anything but actual package init code from __init__.py and just import it from e.g. a core.py or base.py module, but that's a matter of taste, and won't block merging.
|
Merged through svn with the minor changes mentioned in the review. |
jonasbardino
modified the milestones:
Python3 support for general research data sites,
Python3 support for sensitive data sites
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.