Tighten redirect handling in the OpenID service #100
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…cepting redirect there the value may come from an untrusted query argument, which may e.g. have been crafted by the user or even a malicious 3rd party gone phishing. Includes simple inline unit tests for now.
… decoding errors in order to make masking of credentials consistent. Switch from displayResponse to showErrorPage directly to avoid unwanted side effects like e.g. any return_to variables in the request being applied even on such encoding/decoding failure.
…ue if manually mangling login page URL.
albu-diku
reviewed
Aug 6, 2024
albu-diku
reviewed
Aug 6, 2024
…or method up as module function and all test strings up as top-level 'constants'.
|
Manually merged through svn. |
|
For the record the fix is included in the 20240807 and any later releases. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tighten redirects in built-in OpenID service as discussed internally in follow-up to external reporting.