Restore original tool wait delay and make fastboot getvar more robust #105
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Alexander Martinz <amartinz@shiftphones.com>
amartinz
force-pushed
the
amartinz/non-spammy-tools-and-fixed-fastboot-getvar
branch
from
94c73b8 to
c0e329b
Compare
Assuming the first part of the output always contains the variable is wrong. Signed-off-by: Alexander Martinz <amartinz@shiftphones.com>
amartinz
force-pushed
the
amartinz/non-spammy-tools-and-fixed-fastboot-getvar
branch
from
c0e329b to
3001161
Compare
Flohack74
approved these changes
Jun 25, 2025
Flohack74
deleted the
amartinz/non-spammy-tools-and-fixed-fastboot-getvar
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Test
Expected result
Device gets detected
Actual result
Device is not getting detected, because the parsing of
getvarfails as it assumes, that the output always starts withname: variable, whereas this is not the case when freshly connecting the device.It works, if the device is connected before starting UBports Installer because the device connection has settled by then.
With these patches the above scenario is fixed.
Also the delay of the tool wait interval is increased to not spam the host, which would use a lot of ressources on lower end machines.