forked from actions/runner-images
-
Notifications
You must be signed in to change notification settings - Fork 1
Extract common steps to the script files #1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Draft
enescakir
wants to merge
10
commits into
ubicloud
Choose a base branch
from
extract-script
base: ubicloud
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
d9f7b90
to
80ca0d5
Compare
0990436
to
cab186f
Compare
The new version of az cli started to throw an exception for pending downloads. Azure/azure-cli#10160 (comment)
911430a
to
90f9a56
Compare
Huh, why is so much added lines? Are some of the lines actually un-doing stuff done previously? |
fdr
reviewed
May 31, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
.
Add nvidia-cuda-toolkit to the GPU image (#2) Add nvidia-cuda-toolkit and cuda-drivers cuda-12-4 add cudnn add cudnn to env just install cudnn
c2251a3
to
2a334b8
Compare
8a283ae
to
4d02a79
Compare
6a3da93
to
1dfc4c1
Compare
3837ade
to
de08738
Compare
7b06951
to
d80f031
Compare
0ee1bc0
to
c35e5f5
Compare
c18969c
to
e6d96c1
Compare
961d7ba
to
d059f92
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Each packer template has duplicate Ubicloud steps that we can extract into common script files. I've created this pull request for initial feedback. If it seems acceptable to you, I'll rebase my previous commits.