fix: screen should not flash in the dark mode #14
+79
−35
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for clreq-gap-typst ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
YDX-2147483647
requested review from
Myriad-Dreamin and
Copilot
and removed request for
Myriad-Dreamin
There was a problem hiding this comment.
Pull Request Overview
This PR addresses the screen flashing issue in dark mode by ensuring that the theme script is loaded early and properly configured during development and production builds.
- Added a theme entry in vite.config.ts to support early theme loading.
- Updated typ/packages/vite.typ to handle scripts with the #nomodule suffix and refined the script loader logic.
- Introduced src/theme.ts to apply the theme before DOM load and removed its import from src/main.ts, updating index.typ accordingly.
Reviewed Changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| vite.config.ts | Added the theme entry to include the early loading of the theme script. |
| typ/packages/vite.typ | Modified the script loader to parse raw paths and handle the #nomodule suffix. |
| src/theme.ts | Introduced a pre-DOM theme application script and updated the toggle logic. |
| src/main.ts | Removed the theme import to avoid late loading. |
| index.typ | Updated file loading to include the theme script with #nomodule in dev mode. |
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
|
目录还会闪一下，不过先记在 #16，下次解决吧。 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
pnpm build && pnpm preview没问题了。pnpm dev还是闪屏，因为 vite 热重载的脚本需要type=module，加载得晚。