Skip to content

Reduce dependency to railties >= 8.0.0 and activesupport >= 8.0.0 #17

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 3, 2025

Conversation

tangrufus
Copy link
Member

No description provided.

@tangrufus tangrufus added the dependencies Pull requests that update a dependency file label Jun 3, 2025
@tangrufus tangrufus enabled auto-merge (squash) June 3, 2025 00:52
Copy link

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR splits the Rails dependency into its core components and adjusts the dummy application to load all frameworks.

  • Replace the rails gem dependency with separate railties and activesupport dependencies at >= 8.0.0
  • Update the dummy app to use require "rails/all" instead of listing individual railties

Reviewed Changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.

File Description
test/dummy/config/application.rb Simplified framework loading by replacing selective railtie requires with require "rails/all".
rails-app_env.gemspec Removed rails dependency; added railties and activesupport dependencies at >= 8.0.0.
Comments suppressed due to low confidence (2)

test/dummy/config/application.rb:3

  • The dummy app now requires rails/all, but the gemspec no longer depends on the rails gem. This mismatched dependency will cause load failures. You should either re-add the rails gem dependency or revert to requiring the specific railties you need.
require "rails/all"

rails-app_env.gemspec:27

  • The gemspec defines dependencies on railties and activesupport but omits the rails gem, which may be required by some parts of the code (e.g., rails/all). Ensure dependencies align with the frameworks your code actually loads.
spec.add_dependency "railties", rails_version

@@ -23,5 +23,7 @@ Gem::Specification.new do |spec|
Dir["{app,config,db,lib}/**/*", "LICENSE", "Rakefile", "README.md"]
end

spec.add_dependency "rails", ">= 8.0.2"
rails_version = ">= 8.0.0"
Copy link
Preview

Copilot AI Jun 3, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[nitpick] Using an open-ended >= 8.0.0 constraint may allow unintended major-version upgrades that introduce breaking changes. Consider using a pessimistic constraint (e.g., ~> 8.0) or adding an upper bound (< 9.0.0).

Suggested change
rails_version = ">= 8.0.0"
rails_version = ">= 8.0.0, < 9.0.0"

Copilot uses AI. Check for mistakes.

@tangrufus tangrufus merged commit 599a2a6 into main Jun 3, 2025
8 checks passed
@tangrufus tangrufus deleted the gem branch June 3, 2025 01:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file
Development

Successfully merging this pull request may close these issues.

1 participant