Skip to content

Conversation

@zergmk2
Copy link

@zergmk2 zergmk2 commented Oct 7, 2016

Typings URL: https://github.com/zergmk2/typed-stash-rest-api

Questions (for new typings):

  • Does the README explain the purpose of the typings and have a link to the JavaScript project?
  • Do the typings follow the source structure (e.g. index.js <-> index.d.ts)?
  • Are they external or global modules according the source (e.g. see README sources)?

Change Summary (for existing typings):
@felixfbecker
@blakeembrey
Sorry for my mistakenly closing the previous PR, I've updated my repo following your comments.
Could you please review it again? Thank you.

@zergmk2 You should use one from the registry ;)

I've used the "pinkie-promis" module from the registry instead of "promise" module.
https://github.com/zergmk2/typed-stash-rest-api/blob/master/src/index.d.ts#L1

Signed-off-by: Lu_Cao zergmk2@gmail.com

Signed-off-by: Lu_Cao <zergmk2@gmail.com>
@blakeembrey
Copy link
Member

@zergmk2 Sorry for the delay, you've got a typo importing pinkie-promise 😄 You may want to add some tests to make sure it compiles using TypeScript.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants