Don't use archives dependencies

[mernst]

No description provided.

[coderabbitai]

📝 Walkthrough

Walkthrough

The build configuration for both annotation-file-utilities and checker modules was modified to change how JAR artifacts are handled. The archives() artifact declarations were removed or simplified, and the assemble task was explicitly configured to depend on the JAR build tasks (shadowJar, checkerJar, skinnyJar). For the checker module, only the fatJar(shadowJar) artifact declaration remains, while archives() entries for shadowJar, checkerJar, and allSourcesJar were removed.

Possibly related PRs

• Add checker.jar to task output. #7321: Modifies checker/build.gradle with changes to shadowJar and checker.jar build artifact configuration
• Update to the latest version of Shadow. #7331: Updates checker and annotation-file-utilities Gradle scripts to restructure Shadow plugin usage and artifact publishing with similar assemble task dependency patterns
• Disambiguate functions from properties #7332: Alters the same Gradle files' artifact declarations and assemble task dependencies in parallel with this PR's changes

Pre-merge checks and finishing touches

❌ Failed checks (1 warning)

Check name	Status	Explanation	Resolution
Docstring Coverage	⚠️ Warning	Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%.	You can run @coderabbitai generate docstrings to improve docstring coverage.

✨ Finishing touches

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Post copyable unit tests in a comment

---

📜 Recent review details

Configuration used: Path: .coderabbit.yaml

Review profile: ASSERTIVE

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 9f31075 and 72fb369.

📒 Files selected for processing (2)

• annotation-file-utilities/build.gradle (1 hunks)
• checker/build.gradle (1 hunks)

⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (7)

• GitHub Check: typetools.checker-framework (junit_jdk25)
• GitHub Check: typetools.checker-framework (nonjunit_jdk25)
• GitHub Check: typetools.checker-framework (typecheck_part2_jdk25)
• GitHub Check: typetools.checker-framework (typecheck_part1_jdk25)
• GitHub Check: typetools.checker-framework (misc_jdk25)
• GitHub Check: typetools.checker-framework (inference_part2_jdk25)
• GitHub Check: typetools.checker-framework (inference_part1_jdk25)

🔇 Additional comments (2)

annotation-file-utilities/build.gradle (1)

187-190: Clean migration from archives() to explicit assemble dependencies.

Making assemble explicitly depend on both shadowJar and skinnyJar ensures these primary artifacts are built as part of the standard build lifecycle. This aligns well with the PR objective of removing legacy archives() declarations.

checker/build.gradle (1)

195-198: Intentional separation of assemble vs. publishing artifacts.

The addition of explicit assemble dependencies for shadowJar and checkerJar is clean, and the intentional omission of allSourcesJar and allJavadocJar aligns with the comment at line 201. These supplementary artifacts will still be built on-demand during publishing (via artifact() references in the publications block at lines 1050-1052), which is more efficient than building them during every assemble.

To confirm this change doesn't break downstream workflows, please verify that any CI/CD pipeline or custom task that depends on gradle assemble doesn't expect allSourcesJar or allJavadocJar to be pre-built. The publishing task will auto-build them as needed.

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands and usage tips.}