Custom error that includes the response on JSON parse error #44
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Looks like there's some linting errors |
|
Had to bump rubocop-rspec, but it’s good now 👍🏻 |
tharropoulos
approved these changes
Apr 23, 2025
|
@jasonbosco lgtm |
jasonbosco
approved these changes
Apr 23, 2025
|
This is now available in v3.1.0 |
|
Thanks Jason & Fanis! ✨ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change Summary
I’ve been experiencing some errors due to some malformed JSON responses on import.
In order to distinguish which elements were imported correctly and which weren’t it helps to catch the error and return a JSON response for every element.
PR Checklist