-
-
Notifications
You must be signed in to change notification settings - Fork 9
Ground work for integration tests with real instance #43
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Ground work for integration tests with real instance #43
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
First of all, thank you for taking the time to implement those changes!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could we leave dep bumps until after we've merged the test changes? Would prefer to avoid any side effects related to deps here
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
These updates only for dev dependencies, imo would be nice to update these to latest before hand?
Gem dependencies are declared in .gemspec file
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Most of the dep bumps are specifically for testing, so they should be fine. Although, I feel like they should be left as the last thing, so we don't need to bisect if something goes wrong with any dependency.
Change Summary
Related: #42
This PR covers the groundwork for introducing integration/request tests with an actual Docker container;
PR Checklist