Skip to content

Ground work for integration tests with real instance #43

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

erimicel
Copy link
Contributor

@erimicel erimicel commented Mar 10, 2025

Change Summary

Related: #42

This PR covers the groundwork for introducing integration/request tests with an actual Docker container;

  • Adds Ruby 3.4 to CI Matrix
  • Updates dev gems
  • Making sure all collection tests using same schema structure
  • Allow localhost requests in rspec with WebMock

PR Checklist

Copy link
Contributor

@tharropoulos tharropoulos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

First of all, thank you for taking the time to implement those changes!

@erimicel erimicel changed the title Grand work for integration tests with real instance Ground work for integration tests with real instance Mar 11, 2025
@erimicel erimicel requested a review from tharropoulos March 11, 2025 21:05
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could we leave dep bumps until after we've merged the test changes? Would prefer to avoid any side effects related to deps here

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These updates only for dev dependencies, imo would be nice to update these to latest before hand?

Gem dependencies are declared in .gemspec file

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Most of the dep bumps are specifically for testing, so they should be fine. Although, I feel like they should be left as the last thing, so we don't need to bisect if something goes wrong with any dependency.

@erimicel erimicel closed this Apr 2, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants