Implement PollerMetrics for EpollSystem #4335
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
iRevive
reviewed
Apr 13, 2025
core/native/src/main/scala/cats/effect/unsafe/EpollSystem.scala
Outdated
Show resolved
Hide resolved
Co-authored-by: Maksym Ochenashko <maxochenashko@gmail.com>
|
IMO this (and #4336) are very cool and look good and I don't see anything standing in the way of their merge. @armanbilge thoughts? @antoniojimeneznieto do you feel these are in a state where they can be non-WIP PRs? |
armanbilge
reviewed
Jul 23, 2025
| private var totalWriteCanceled = 0L | ||
| private var writeOutstanding = 0 | ||
|
|
||
| private[this] val pollerMetrics: PollerMetrics = new PollerMetrics { |
There was a problem hiding this comment.
Instead of an internal object, we can have Poller extends PollerMetrics and implement these methods directly :)
There was a problem hiding this comment.
That makes sense! Thank you arman :)
Yes, thank you! I believe they're ready and no longer WIP |
djspiewak
approved these changes
Jul 26, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Linked to: #4314
This PR implements metrics tracking for read and write operations in the Poller class for the EpollSystem. It provides basic metrics reporting such as total submitted, succeeded, errored, and canceled operations and outstanding operations count.