Skip to content

Run different version of mypy in ci #2671

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 4 commits into
base: master
Choose a base branch
from
Open

Run different version of mypy in ci #2671

wants to merge 4 commits into from

Conversation

UnknownPlatypus
Copy link
Contributor

@UnknownPlatypus UnknownPlatypus commented May 9, 2025 •
edited
Loading

I have made things!

Run ci with supported mypy version ie 1.13, 1.14, 1.15, 1.16 and master branch on github.

sobolevn
sobolevn reviewed May 9, 2025
View reviewed changes
@UnknownPlatypus UnknownPlatypus force-pushed the test-minimal-supported-mypy-version branch from 843be52 to 5ade464 Compare June 1, 2025 15:05
@UnknownPlatypus UnknownPlatypus force-pushed the test-minimal-supported-mypy-version branch from a5c9dec to f328c33 Compare June 7, 2025 12:54
@UnknownPlatypus
Copy link
Contributor Author

@sobolevn This is ready for review, was much easier now that we have uv.
I had to use type: ignore[unused-ignore] for type ignores that were required on old versions but not required in newer ones.
We should aim at removing them when we drop older mypy/python version support

sobolevn
sobolevn reviewed Jun 7, 2025
View reviewed changes
Copy link
Member

@sobolevn sobolevn left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am not quite sure about that :(
It brings several new quirks for maintenance, not sure if it really helps though...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sobolevn sobolevn sobolevn left review comments

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@UnknownPlatypus @sobolevn