Skip to content

Add server_status message to the raft peering service #229

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: cluster-support-feature-branch
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions proto/BUILD
Original file line number Diff line number Diff line change
Expand Up @@ -31,6 +31,9 @@ proto_library(
proto_library(
name = "raft-peering-proto",
srcs = [":raft-peering.proto"],
deps = [
":server-proto",
],
)

proto_library(
Expand Down
7 changes: 6 additions & 1 deletion proto/raft-peering-service.proto
Original file line number Diff line number Diff line change
@@ -1,9 +1,14 @@
// This Source Code Form is subject to the terms of the Mozilla Public
// License, v. 2.0. If a copy of the MPL was not distributed with this
// file, You can obtain one at https://mozilla.org/MPL/2.0/.

syntax = "proto3";

import "proto/raft-peering.proto";

package typedb.protocol;

service RaftPeering {
rpc Peering(PeeringRequest) returns (PeeringResponse);
rpc peering (Peering.Req) returns (Peering.Res);
rpc server_status (ServerStatus.Req) returns (ServerStatus.Res);
}
29 changes: 24 additions & 5 deletions proto/raft-peering.proto
Original file line number Diff line number Diff line change
@@ -1,12 +1,31 @@
// This Source Code Form is subject to the terms of the Mozilla Public
// License, v. 2.0. If a copy of the MPL was not distributed with this
// file, You can obtain one at https://mozilla.org/MPL/2.0/.

syntax = "proto3";

package typedb.protocol;

message PeeringRequest {
uint64 from_id = 1;
string from_address = 2;
bytes message = 3;
import "proto/server.proto";

message Peering {
message Req {
uint64 from_id = 1;
string from_address = 2;
bytes message = 3;
}

message Res {}
}

message PeeringResponse {
message ServerStatus {
message Req {}

message Res {
// TODO: Currently, it's identical to Server. But it won't necessarily be the case forever, so these fields are
// split. Additionally, we want to highlight that the address is the connection address.
// TODO: We may move ReplicaStatus somewhere else now...
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These todos are more like PR comments. I think it's fine as is now.

string connection_address = 1;
Server.ReplicaStatus replica_status = 2;
}
}