This repository was archived by the owner on Dec 7, 2022. It is now read-only.
Add chance attribute to blockdrops. #1040
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pugzy
force-pushed
the
drop-chance
branch
2 times, most recently
from
d7e067b to
ddd013a
Compare
- Add chances to item drops. - Gather wrongtool info when attribute and element. - Fix usage of wrongtool. - Fix giving incorrect experience.
|
Looks good, I'm fine with this being merged. I don't know if @Pablete1234 has other opinions. |
|
@twizmwazin It's not ready yet, trample and punch don't work, @iPGz was waiting for cause filters to be implemented first |
|
I still see some debug messages and tests arround, so i'm labeling as WIP |
Pablete1234
reviewed
Nov 23, 2016
|
|
||
| @EventHandler(priority = EventPriority.MONITOR) | ||
| public void onPlayerAnimation(PlayerInteractEvent event) { // event not triggering with right click | ||
| if (!event.isCancelled()) { |
There was a problem hiding this comment.
replace with:
@EventHandler(priority = EventPriority.MONITOR, ignoreCancelled = true)
Pugzy
commented
Nov 23, 2016
| xp.setExperience(this.experience); | ||
| } | ||
| if (this.kit != null) { | ||
| kit.apply(player, true); // should be true? forced? |
There was a problem hiding this comment.
null this true, the wise man @Pablete1234 told me to.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I found most of these issues whilst testing #1039 so I thought I'd fix them too.
This class could do with a re-write to enable the
punchandtrampleelements in the future.chances to item drops.wrongtoolinfo when attribute and element.wrongtool.experience.Update 1:
Update 2:
generateDrops()to be used in all events.trampleandpunch.