fix: resolve manifest generation issues, update oclif tooling #71
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Tierney Cyren <hello@bnb.im>
Signed-off-by: Tierney Cyren <hello@bnb.im>
Signed-off-by: Tierney Cyren <hello@bnb.im>
Signed-off-by: Tierney Cyren <hello@bnb.im>
Signed-off-by: Tierney Cyren <hello@bnb.im>
Signed-off-by: Tierney Cyren <hello@bnb.im>
Signed-off-by: Tierney Cyren <hello@bnb.im>
micaswyers-work
approved these changes
Mar 14, 2025
| @@ -7,7 +7,7 @@ Generate a temporary token for use in a Twilio client-side SDK application | |||
| * [Requirements](#requirements) | |||
| * [Usage](#usage) | |||
| * [Commands](#commands) | |||
| * [ Contributing](#contributing) | |||
| * [ Contributing](#-contributing) | |||
There was a problem hiding this comment.
What does the - do here?
| @@ -49,7 +49,7 @@ class FlexTokenGenerator extends TwilioClientCommand { | |||
| } | |||
|
|
|||
| const globals = { ...globalFlags }; | |||
| globals.identity = undefined; | |||
| delete globals.identity; | |||
There was a problem hiding this comment.
Checking my understanding:
Biome generally flags noDelete, but you've added the delete back in and updated biome to only warn about it.
Was setting globals.identity = undefined one of the reasons we were running into trouble while pairing? Was this at all related to oclif (vs. oclif-dev) barfing?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR resovles manifest generation issues. Specifically, it reverts two changes that were made to remove using
deletewith variables, assigning them toundefinedinstead. I've also updated biome towarnrather thanerroron these instances - we do want to change the instances ofdeleteeventually, but it's fine to keep them in for now. I've also run the readme update tool that oclif provides, which has implemented a number of changes.Additionally, I've updated
ocliftooling to use the versions supported by oclif now and have added npm scripts so we don't have to remember which commands we need to run.Contributing to Twilio