Timeline interactive #4336
Merged
Timeline interactive #4336
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
🦋 Changeset detectedLatest commit: 8845a8a The changes in this PR will be included in the next version bump. This PR includes changesets to release 2 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
github-actions
bot
added
Area: Components
|
View your CI Pipeline Execution ↗ for commit 8845a8a.
☁️ Nx Cloud last updated this comment at |
|
View your CI Pipeline Execution ↗ for commit fd2ec1b.
☁️ Nx Cloud last updated this comment at |
|
Size Change: +182 B (0%) Total Size: 1.13 MB
ℹ️ View Unchanged
|
dosubot
bot
added
the
size:L
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit 8845a8a:
|
PixeledCode
force-pushed
the
timeline-interactive
branch
from
eeaa714 to
a6be91e
Compare
github-actions
bot
added
Type: Documentation
Paste
|
||||||||||||||||||||||||||||
| Project |
Paste
|
| Branch Review |
timeline-interactive
|
| Run status |
|
| Run duration | 04m 02s |
| Commit |
|
| Committer | PixeledCode |
| View all properties for this run ↗︎ | |
| Test results | |
|---|---|
Failures
|
0
|
Flaky
|
0
|
Pending
|
0
|
Skipped
|
0
|
Passing
|
69
|
| View all changes introduced in this branch ↗︎ | |
|
TODO: I didn't specify it in the task, but can we add a section with example in Timeline docs for this, add it under Timeline first example Timeline with interactive titlesUse interactive titles only when the Timeline Event links to a specific moment in another view or surface. [warning callout] These titles should be used only when the event exists elsewhere and the user needs to be redirected to that exact point in time. If the event doesn't have a corresponding view, use a non-interactive title instead. |
|
TODO: Also for docs under Accessibility update the first bullet to read like this:
|
PixeledCode
force-pushed
the
timeline-interactive
branch
from
eb20d9a to
8845a8a
Compare
krisantrobus
reviewed
Jun 2, 2025
Comment on lines
+93
to
+95
| <ListItem> | ||
| The toggle button when using the `collapsible` prop: `collapsible` TimelineItems use the <Anchor href="/components/summary-detail">Summary Detail</Anchor> component. The toggle button is labeled by the value of the `timestamp` prop. If the value is too verbose for a screen reader or not a clear label for the collapsed content, provide a helpful label for the button using the collapsibleLabelText prop on TimelineItem. | ||
| </ListItem> |
roxanagomez
approved these changes
Jun 3, 2025
PixeledCode
added
🚀 merge it!
🕵🏻♀️ Run website visual regression
Paste
|
||||||||||||||||||||||||||||
| Project |
Paste
|
| Branch Review |
timeline-interactive
|
| Run status |
|
| Run duration | 07m 32s |
| Commit |
|
| Committer | Shoaib Ahmed |
| View all properties for this run ↗︎ | |
| Test results | |
|---|---|
|
Failures
|
0
|
|
Flaky
|
0
|
|
Pending
|
0
|
|
Skipped
|
0
|
|
Passing
|
125
|
| View all changes introduced in this branch ↗︎ | |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://paste-docs-git-timeline-interactive-twilio.vercel.app