Skip to content

feat(data-viz): add simple chart type support #4318

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 65 commits into from
Jun 18, 2025

Conversation

krisantrobus
Copy link
Collaborator

Data Visualization Enhancements:

  • Updated Highcharts native tooltip styles in the @twilio-paste/data-visualization-library to align with Paste styles, including font family adjustments.
  • Added helper functions and types in the @twilio-paste/data-visualization-library to support creating Highcharts options for supported chart types.
  • Extended the ChartProvider component to allow usage of options for supported chart types.

Updates

  • Updated the ChartProvider documentation for supported charts and enhanced API section /components/chart-provider/api
  • Added multiple examples to the /foundations/data-visualization/engineering/chart-types page

@@ -20,6 +20,7 @@
"scripts": {
"build": "yarn clean && NODE_ENV=production node build.js && tsc",
"build:js": "NODE_ENV=development node build.js",
"build:typedocs": "tsx ../../../tools/build/generate-type-docs --skipPropsNameRule",
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👏

nkrantz
nkrantz previously approved these changes May 28, 2025
Copy link
Collaborator

@nkrantz nkrantz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

great tests and examples!

@dosubot dosubot bot added the lgtm This PR has been approved by a maintainer label May 28, 2025
PixeledCode
PixeledCode previously approved these changes Jun 18, 2025
Copy link

cypress bot commented Jun 18, 2025

Paste    Run #9875

Run Properties:  status check passed Passed #9875  •  git commit 43b5cbccea ℹ️: Merge 9469de0afd1fab2b55ad00e83296bafd4d7ae0d0 into 8ee187d851fb996f4c8ec2a04841...
Project Paste
Branch Review chart-types-line-column-support
Run status status check passed Passed #9875
Run duration 07m 42s
Commit git commit 43b5cbccea ℹ️: Merge 9469de0afd1fab2b55ad00e83296bafd4d7ae0d0 into 8ee187d851fb996f4c8ec2a04841...
Committer krisantrobus
View all properties for this run ↗︎

Test results
Tests that failed  Failures 0
Tests that were flaky  Flaky 0
Tests that did not run due to a developer annotating a test with .skip  Pending 0
Tests that did not run due to a failure in a mocha hook  Skipped 0
Tests that passed  Passing 125
View all changes introduced in this branch ↗︎

@kodiakhq kodiakhq bot merged commit 3705495 into main Jun 18, 2025
50 checks passed
@kodiakhq kodiakhq bot deleted the chart-types-line-column-support branch June 18, 2025 15:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area: Components Related to the component library (core) of this system Area: Doc Site Related to the documentation website Area: Infrastructure Related to our infrastructure and build tools Area: Repo lgtm This PR has been approved by a maintainer 🚀 merge it! 🕵🏻‍♀️ Run website visual regression When applied, we will run a full suite of visual regression tests across the doc site size:XXL This PR changes 1000+ lines, ignoring generated files. Type: Documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants