-
Notifications
You must be signed in to change notification settings - Fork 119
feat(data-viz): add simple chart type support #4318
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nkrantz
reviewed
May 28, 2025
@@ -20,6 +20,7 @@ | |||
"scripts": { | |||
"build": "yarn clean && NODE_ENV=production node build.js && tsc", | |||
"build:js": "NODE_ENV=development node build.js", | |||
"build:typedocs": "tsx ../../../tools/build/generate-type-docs --skipPropsNameRule", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👏
nkrantz
previously approved these changes
May 28, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
great tests and examples!
PixeledCode
previously approved these changes
Jun 18, 2025
Paste
|
Project |
Paste
|
Branch Review |
chart-types-line-column-support
|
Run status |
|
Run duration | 07m 42s |
Commit |
|
Committer | krisantrobus |
View all properties for this run ↗︎ |
Test results | |
---|---|
|
0
|
|
0
|
|
0
|
|
0
|
|
125
|
View all changes introduced in this branch ↗︎ |
jhanvi1399
approved these changes
Jun 18, 2025
roxanagomez
approved these changes
Jun 18, 2025
nkrantz
approved these changes
Jun 18, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Area: Components
Related to the component library (core) of this system
Area: Doc Site
Related to the documentation website
Area: Infrastructure
Related to our infrastructure and build tools
Area: Repo
lgtm
This PR has been approved by a maintainer
🚀 merge it!
🕵🏻♀️ Run website visual regression
When applied, we will run a full suite of visual regression tests across the doc site
size:XXL
This PR changes 1000+ lines, ignoring generated files.
Type: Documentation
Improvements or additions to documentation
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Data Visualization Enhancements:
@twilio-paste/data-visualization-library
to align with Paste styles, including font family adjustments.@twilio-paste/data-visualization-library
to support creating Highcharts options for supported chart types.ChartProvider
component to allow usage of options for supported chart types.Updates
ChartProvider
documentation for supported charts and enhanced API section/components/chart-provider/api
/foundations/data-visualization/engineering/chart-types
page