chore(chat-composer): adjust spacing, make icon optional #4292
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
🦋 Changeset detectedLatest commit: ada014a The changes in this PR will be included in the next version bump. This PR includes changesets to release 2 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
dosubot
bot
added
the
size:M
github-actions
bot
added
Type: Documentation
|
View your CI Pipeline Execution ↗ for commit ada014a.
☁️ Nx Cloud last updated this comment at |
nkrantz
commented
Mar 31, 2025
There was a problem hiding this comment.
Technically this is a breaking change, removing the Media Object from the Chat Composer file. If anyone is using the Customization Provider to target "CHAT_COMPOSER_MEDIA_OBJECT" that will break. I think it's safe to mark this as a patch based on the likelihood of that being used, but leaving it open for discussion.
|
Size Change: -1.34 kB (0%) Total Size: 1.12 MB
ℹ️ View Unchanged
|
Paste
|
||||||||||||||||||||||||||||
| Project |
Paste
|
| Branch Review |
attachment-card/updates
|
| Run status |
|
| Run duration | 06m 02s |
| Commit |
|
| Committer | Nora Krantz |
| View all properties for this run ↗︎ | |
| Test results | |
|---|---|
Failures
|
0
|
Flaky
|
1
|
Pending
|
0
|
Skipped
|
0
|
Passing
|
67
|
| View all changes introduced in this branch ↗︎ | |
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit ada014a:
|
| "@twilio-paste/core": patch | ||
| --- | ||
|
|
||
| [Chat Composer] Make `attachmentIcon` optional for the attachment card, adjust spacing slightly. NOTE: if you are using the Customization Provider to target "CHAT_COMPOSER_MEDIA_OBJECT", you will need to update your styles as Media Object is no longer being used in the Chat Composer package. |
There was a problem hiding this comment.
👏 great communication for potential changes needed
krisantrobus
approved these changes
Mar 31, 2025
PixeledCode
approved these changes
Apr 1, 2025
serifluous
approved these changes
Apr 1, 2025
serifluous
added
the
🕵🏻♀️ Run website visual regression
Paste
|
||||||||||||||||||||||||||||
| Project |
Paste
|
| Branch Review |
attachment-card/updates
|
| Run status |
|
| Run duration | 07m 42s |
| Commit |
|
| Committer | Nora Krantz |
| View all properties for this run ↗︎ | |
| Test results | |
|---|---|
|
Failures
|
0
|
|
Flaky
|
0
|
|
Pending
|
0
|
|
Skipped
|
0
|
|
Passing
|
125
|
| View all changes introduced in this branch ↗︎ | |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Contributing to Twilio