feat(storybook): working stories #4265
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
|
dosubot
bot
added
the
size:M
github-actions
bot
added
Area: Storybook
krisantrobus
commented
Mar 7, 2025
| @@ -1,4 +1,5 @@ | |||
| const { addons } = require("@storybook/addons"); | |||
| const { addons } = require("@storybook/manager-api"); | |||
There was a problem hiding this comment.
They deprecated the other package
krisantrobus
commented
Mar 7, 2025
Comment on lines
+64
to
+66
| docs: { | ||
| autodocs: false, | ||
| }, |
There was a problem hiding this comment.
Kept this option in as we can set true to create docs. It's pretty cool, creates a prop tables and gives a preview of all storybooks. I disabled though because they could be pretty long depending on how many stories a component has and could potentially hit the chromatic length limit and fail our tests. We can investigate in future but we didn't have it origionally so not required
krisantrobus
commented
Mar 7, 2025
| @@ -281,7 +281,6 @@ export const decorators = [ | |||
|
|
|||
| export const parameters = { | |||
| isTestEnvironment, | |||
| actions: { argTypesRegex: "^on[A-Z].*" }, | |||
krisantrobus
commented
Mar 7, 2025
| "@storybook/addon-essentials": "7.6.4", | ||
| "@storybook/addon-interactions": "7.6.4", | ||
| "@storybook/addon-links": "7.6.4", | ||
| "@storybook/addons": "7.6.4", |
krisantrobus
commented
Mar 7, 2025
| "@storybook/react": "7.6.4", | ||
| "@storybook/react-vite": "7.6.4", | ||
| "@storybook/test-runner": "0.16.0", | ||
| "@storybook/testing-library": "0.2.2", |
|
View your CI Pipeline Execution ↗ for commit 33857c6.
☁️ Nx Cloud last updated this comment at |
krisantrobus
commented
Mar 7, 2025
|
|
||
| // eslint-disable-next-line import/no-default-export | ||
| export default { | ||
| title: "Components/Sidebar/FullCompositions", | ||
| title: "Components/Sidebar/Docs", |
There was a problem hiding this comment.
We already had another storybook with the same name and the new version failed to compile with it. This is for the docs site so more appropriately named
github-actions
bot
removed
the
Area: Doc Site
|
Size Change: 0 B Total Size: 1.12 MB ℹ️ View Unchanged
|
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit 33857c6:
|
Paste
|
||||||||||||||||||||||||||||
| Project |
Paste
|
| Branch Review |
upgrade-react-19-storybook
|
| Run status |
|
| Run duration | 04m 57s |
| Commit |
|
| Committer | Kristian Antrobus |
| View all properties for this run ↗︎ | |
| Test results | |
|---|---|
Failures
|
0
|
Flaky
|
0
|
Pending
|
0
|
Skipped
|
0
|
Passing
|
67
|
| View all changes introduced in this branch ↗︎ | |
krisantrobus
changed the title
kodiakhq bot
pushed a commit
that referenced
this pull request
Mar 19, 2025
* feat(core): update react version to 19 * feat(core): address TS errors * feat(core): update yarn lock * feat(core): update button tests * feat(core): format * feat(core): import JSX type * feat(core): format * feat(core): update type docs * feat(website): update to next 15 * feat(core): update package json of website * feat(core): run codemod * feat(core): update emotion * feat(core): replace ReactChild with ReactNode * feat(core): fix api path * feat(core): replace css with style * React 19 intersection (#4262) * feat(website): replace react-visibility-sensor with react-intersection-observer * feat(website): fix build * feat(core): fix biome * feat(core): fix tests * feat(core): fix styling * feat(core): update typedocs * feat(website): fix build * feat(button): fix reset button * feat(core): remove react 16 tests * feat(core): update doc * feat(core): update yarn file for tests * feat(core): update testing-library for react 18 tests * feat(core): update yarn file * feat(core): update importd * feat(storybook): working stories (#4265) * feat(storybook): working stories * feat(pr): polish for review * feat(ci): vix inherited versions for CI * fix(theme): fix broken storybook * fix(types): add correct types for react 19 codemod changes (#4266) * fix(types): add correct types for react 19 codemod changes * feat(progress-bar): add interval type --------- Co-authored-by: PixeledCode <ashoaib540918@gmail.com> * feat(core): remove react 16 from peer dependencies * feat(core): add changeset * Update changeset Co-authored-by: Nora Krantz <75342690+nkrantz@users.noreply.github.com> * feat(core): update changeset --------- Co-authored-by: krisantrobus <55083528+krisantrobus@users.noreply.github.com> Co-authored-by: Nora Krantz <75342690+nkrantz@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Upgraded the version of Storybook to get it running again. required some additional dependency updates