-
Notifications
You must be signed in to change notification settings - Fork 119
Elevation component changes #4226
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from 41 commits
Commits
Show all changes
48 commits
Select commit
Hold shift + click to select a range
9014fdc
feat(side-panel): add elevation changes
PixeledCode 8f156b5
feat(minimizable-dialog): add elevation changes
PixeledCode 2f80f75
feat(side-modal): add elevation changes
PixeledCode 4d547af
feat(input): add elevation changes
PixeledCode b66c60d
feat(tooltip): add elevation changes
PixeledCode 57f78a3
feat(callout): add elevation changes
PixeledCode d38bf69
feat(topbar): add elevation changes
PixeledCode 9c68a2b
feat(side-panel): update footer and header tokens
PixeledCode 70e5636
feat(chat-composer): update tokens for elevation
PixeledCode d4a29b9
feat(chat-log): update tokens for elevation
PixeledCode 6ebbcbe
feat(side-panel): remove background color from header and footer
PixeledCode dfc6198
feat(topbar): remove border bottom
PixeledCode 629c914
feat(sidebar): update tokens for elevation
PixeledCode d7ebf55
feat(menu): update tokens for elevation
PixeledCode 518c6f4
feat(user-dialog): update tokens for elevation
PixeledCode 8da65b9
feat(combobox): update tokens for elevation
PixeledCode 08b7a61
feat(popover): update tokens for elevation
PixeledCode 72fdc82
feat(toast): update tokens for elevation
PixeledCode 207aa8d
feat(modal): update tokens for elevation
PixeledCode 462d5d4
feat(sidebar): remove commented code
PixeledCode 08de6c1
feat(paste): add changeset
PixeledCode e1b11a8
feat(input): update default background token
PixeledCode 89e7a2c
feat(input): update increament and decreament background token
PixeledCode b77590d
feat(minimizable-dialog): remove unused import
PixeledCode d2664a3
feat(side-modal): remove extra tokens
PixeledCode 33f1ab7
feat(input-box): removed unused import
PixeledCode a8df70b
feat(side-panel): update hover token
PixeledCode 6d68a63
feat(elevation): changes from review
PixeledCode 14a9ad7
feat(sidepanel): update tokens
PixeledCode 09f4aec
feat(sidebar): update tokens
PixeledCode 6c15853
feat(tokens): add shadow-elevation-top-20 token
PixeledCode f295932
feat(elevation): update componets to use new token
PixeledCode 02a7309
feat(elevation): add new token color-background-strong-elevation
PixeledCode 07d5b6d
feat(chat-log): update background color
PixeledCode c0f8b12
feat(elevation): add changeset
PixeledCode cb91e54
feat(elevation): update typedocs
PixeledCode 94105a0
feat(tokens): add color-background-strong-elevation for dark theme
PixeledCode 642df3f
feat(tokens): update comments
PixeledCode f76c569
Merge branch 'main' into elevation-component-changes
PixeledCode 80eab76
feat(elevation): implement changes from chromatic review
PixeledCode 983c7f6
feat(chat-composer): fix disable text color
PixeledCode 372691c
feat(elevation): update sidepanel box shadow
PixeledCode 1e985ce
feat(elevation): fix chat composer placeholder text color
PixeledCode 5056cd5
feat(elevation): update combobox item background and tokens
PixeledCode dce378c
feat(elevation): update background tokens
PixeledCode 96f5903
feat(elevation): update test
PixeledCode 16b3794
feat(elevation): update tokens
PixeledCode d807bfe
Merge branch 'main' into elevation-component-changes
kodiakhq[bot] File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,6 @@ | ||
--- | ||
"@twilio-paste/design-tokens": minor | ||
"@twilio-paste/core": minor | ||
--- | ||
|
||
[Design Tokens] Add new box shadow and background color tokens for elevation |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,22 @@ | ||
--- | ||
"@twilio-paste/callout": patch | ||
"@twilio-paste/chat-composer": patch | ||
"@twilio-paste/chat-log": patch | ||
"@twilio-paste/combobox": patch | ||
"@twilio-paste/input": patch | ||
"@twilio-paste/input-box": patch | ||
"@twilio-paste/menu": patch | ||
"@twilio-paste/minimizable-dialog": patch | ||
"@twilio-paste/modal": patch | ||
"@twilio-paste/popover": patch | ||
"@twilio-paste/side-modal": patch | ||
"@twilio-paste/side-panel": patch | ||
"@twilio-paste/sidebar": patch | ||
"@twilio-paste/toast": patch | ||
"@twilio-paste/tooltip": patch | ||
"@twilio-paste/topbar": patch | ||
"@twilio-paste/user-dialog": patch | ||
"@twilio-paste/core": patch | ||
--- | ||
|
||
[Callout, ChatComposer, ChatLog, Combobox, Input, InputBox, Menu, MinimizableDialog, Modal, Popover, SideModal, SidePanel, Sidebar, Toast, Tooltip, Topbar, UserDialog]: Update styles to implement new elevation tokens |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
30 changes: 16 additions & 14 deletions
30
packages/paste-core/components/minimizable-dialog/src/StyledMinimizableDialog.tsx
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,22 +1,24 @@ | ||
import { Box } from "@twilio-paste/box"; | ||
import type { BoxProps } from "@twilio-paste/box"; | ||
import { Box } from "@twilio-paste/box"; | ||
import * as React from "react"; | ||
|
||
export const StyledMinimizableDialog: React.FC<React.PropsWithChildren<Pick<BoxProps, "element">>> = ({ | ||
element, | ||
children, | ||
}) => ( | ||
<Box | ||
element={element} | ||
borderRadius="borderRadius20" | ||
display="flex" | ||
flexDirection="column" | ||
backgroundColor="colorBackgroundBody" | ||
width="size40" | ||
boxShadow="shadow" | ||
> | ||
{children} | ||
</Box> | ||
); | ||
}) => { | ||
return ( | ||
<Box | ||
element={element} | ||
borderRadius="borderRadius20" | ||
display="flex" | ||
flexDirection="column" | ||
backgroundColor="colorBackgroundWeaker" | ||
width="size40" | ||
boxShadow="shadowElevationTop20" | ||
> | ||
{children} | ||
</Box> | ||
); | ||
}; | ||
|
||
StyledMinimizableDialog.displayName = "StyledMinimizableDialog"; |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.