fix(form-pill): fix issues where pill text not being truncated #4047
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
🦋 Changeset detectedLatest commit: 2186bfa The changes in this PR will be included in the next version bump. This PR includes changesets to release 3 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
dosubot
bot
added
the
size:L
github-actions
bot
added
the
Status: Do Not Merge
github-actions
bot
added
the
Area: Components
☁️ Nx Cloud ReportCI is running/has finished running commands for commit 2186bfa. As they complete they will appear below. Click to see the status, the terminal output, and the build insights. 📂 See all runs for this CI Pipeline Execution ✅ Successfully ran 1 targetSent with 💌 from NxCloud. |
|
Size Change: +181 B (0%) Total Size: 1.09 MB
ℹ️ View Unchanged
|
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit 2186bfa:
|
Paste
|
||||||||||||||||||||||||||||
| Project |
Paste
|
| Branch Review |
fix/multiselect-pill-long-text
|
| Run status |
|
| Run duration | 02m 18s |
| Commit |
|
| Committer | kodiakhq[bot] |
| View all properties for this run ↗︎ | |
| Test results | |
|---|---|
Failures
|
0
|
Flaky
|
0
|
Pending
|
0
|
Skipped
|
0
|
Passing
|
67
|
| View all changes introduced in this branch ↗︎ | |
PixeledCode
reviewed
Aug 27, 2024
serifluous
reviewed
Aug 29, 2024
packages/paste-core/components/combobox/stories/MultiselectCombobox.stories.tsx
Outdated
Show resolved
Hide resolved
nkrantz
reviewed
Aug 29, 2024
…bobox.stories.tsx Co-authored-by: Sarah <sali@twilio.com>
…ix/multiselect-pill-long-text
…bs/paste into fix/multiselect-pill-long-text
nkrantz
reviewed
Aug 30, 2024
| ); | ||
| }; | ||
|
|
||
| PillNarrowContainerFormattedTextContent.storyName = "Pill Narrow Container Formatted Text Content"; |
There was a problem hiding this comment.
suggestion(non-blocking) this line isn't necessary unless you're changing the name of the story, adds errors to the file
nkrantz
reviewed
Aug 30, 2024
| /> | ||
| ) : null} | ||
| {index % 3 === 1 ? <CalendarIcon decorative size={size === "large" ? "sizeIcon20" : "sizeIcon10"} /> : null} | ||
| <Text fontWeight="fontWeightBold" fontStyle="italic"> |
There was a problem hiding this comment.
issue: Text should have an as prop
nkrantz
reviewed
Aug 30, 2024
| }> | ||
| > = ({ selected = false, dismissable = true, disabled = false, ariaLabel = "Basic pills:", size }) => { | ||
| const pillState = useFormPillState(); | ||
| const pillState2 = useFormPillState(); |
There was a problem hiding this comment.
suggestion(non-blocking): should this line be removed? doesn't look like it's being used
nkrantz
reviewed
Aug 30, 2024
packages/paste-core/components/form-pill-group/stories/index.stories.tsx
Outdated
Show resolved
Hide resolved
nkrantz
reviewed
Aug 30, 2024
…tories.tsx Co-authored-by: Nora Krantz <75342690+nkrantz@users.noreply.github.com>
nkrantz
approved these changes
Aug 30, 2024
serifluous
approved these changes
Aug 30, 2024
krisantrobus
added
the
🕵🏻♀️ Run website visual regression
Paste
|
||||||||||||||||||||||||||||
| Project |
Paste
|
| Branch Review |
fix/multiselect-pill-long-text
|
| Run status |
|
| Run duration | 06m 06s |
| Commit |
|
| Committer | krisantrobus |
| View all properties for this run ↗︎ | |
| Test results | |
|---|---|
|
Failures
|
0
|
|
Flaky
|
0
|
|
Pending
|
0
|
|
Skipped
|
0
|
|
Passing
|
125
|
| View all changes introduced in this branch ↗︎ | |
krisantrobus
added
🚀 merge it!
and removed
Status: Do Not Merge
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses an issue where form pill text would wrap when it is longer than form pill group parent.
Key considerations when working with FormPillGroup. As FormPillGroup wraps the pills there should be no ability to overflow the width of the formPillGroup, only to stretch as far as the parent group. In order to achieve this I need to find the string of the children as it could potentially be be composed like our storybooks. Apply the truncate only to the string. Currently for pill we would see the same issue with long text as we were already seeing in the original bug, it is not limited to being in a popover but to any narrow container.
Before:
After:
