Fix/button resize plus ai bug #4026
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
krisantrobus
commented
Aug 8, 2024
krisantrobus
commented
- Addresses issue with typescript exposing props on popover reset variant
- Correctly sets decorative AI icon color
- Fixes naming and customization on AI examples
|
|
dosubot
bot
added
the
size:M
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
🦋 Changeset detectedLatest commit: 2f0578b The changes in this PR will be included in the next version bump. This PR includes changesets to release 3 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
github-actions
bot
added
the
Status: Do Not Merge
github-actions
bot
added
Type: Documentation
☁️ Nx Cloud ReportCI is running/has finished running commands for commit 2f0578b. As they complete they will appear below. Click to see the status, the terminal output, and the build insights. 📂 See all runs for this CI Pipeline Execution ✅ Successfully ran 1 targetSent with 💌 from NxCloud. |
krisantrobus
commented
Aug 8, 2024
| @@ -13,7 +13,7 @@ type PopoverButtonBaseProps = { | |||
| }; | |||
|
|
|||
| export type PopoverButtonProps = PopoverButtonBaseProps & | |||
| Omit<ButtonProps, "as"> & { | |||
There was a problem hiding this comment.
Adding the Omit is messing with the underlying types. With omit it will not show additional pseudo types for reset in an IDE. Removing it fixes this.
I manually tested setting the "as" prop to be something other than button and it had no effect as button is applied in the button component it renders.
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit 2f0578b:
|
|
Size Change: +3 B (0%) Total Size: 1.09 MB
ℹ️ View Unchanged
|
|
Test summaryRun details
This comment has been generated by cypress-bot as a result of this project's GitHub integration settings. You can manage this integration in this project's settings in the Cypress Cloud |
serifluous
reviewed
Aug 8, 2024
packages/paste-website/src/pages/components/ai-chat-log/index.mdx
Outdated
Show resolved
Hide resolved
Co-authored-by: Sarah <sali@twilio.com>
serifluous
approved these changes
Aug 8, 2024
nkrantz
approved these changes
Aug 13, 2024
krisantrobus
added
the
🕵🏻♀️ Run website visual regression
|
Test summaryRun details
This comment has been generated by cypress-bot as a result of this project's GitHub integration settings. You can manage this integration in this project's settings in the Cypress Cloud |
krisantrobus
added
🚀 merge it!
and removed
Status: Do Not Merge
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.