Fix theme flash on paste website #4025
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
|
dosubot
bot
added
the
size:S
github-actions
bot
added
Status: Do Not Merge
☁️ Nx Cloud ReportCI is running/has finished running commands for commit 4d82d58. As they complete they will appear below. Click to see the status, the terminal output, and the build insights. 📂 See all runs for this CI Pipeline Execution ✅ Successfully ran 1 targetSent with 💌 from NxCloud. |
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit 4d82d58:
|
|
Size Change: 0 B Total Size: 1.09 MB ℹ️ View Unchanged
|
|
Test summaryRun details
This comment has been generated by cypress-bot as a result of this project's GitHub integration settings. You can manage this integration in this project's settings in the Cypress Cloud |
krisantrobus
reviewed
Aug 7, 2024
krisantrobus
reviewed
Aug 7, 2024
| @@ -13,7 +13,7 @@ const ValidThemes = { | |||
| type ValidThemeName = ValueOf<typeof ValidThemes>; | |||
|
|
|||
| const isValidTheme = (themeName: ValidThemeName): boolean => { | |||
| return themeName === ValidThemes.DEFAULT || themeName === ValidThemes.DARK; | |||
| return Object.values(ValidThemes).includes(themeName); | |||
There was a problem hiding this comment.
praise: I like the scalable refactor 👏
krisantrobus
reviewed
Aug 7, 2024
serifluous
approved these changes
Aug 7, 2024
PixeledCode
added
🚀 merge it!
🕵🏻♀️ Run website visual regression
|
Test summaryRun details
This comment has been generated by cypress-bot as a result of this project's GitHub integration settings. You can manage this integration in this project's settings in the Cypress Cloud |
PixeledCode
added a commit
that referenced
this pull request
Feb 19, 2025
This reverts commit fb4cbc5.
kodiakhq bot
added a commit
that referenced
this pull request
Feb 25, 2025
* Revert "Fix theme flash on paste website (#4025)" This reverts commit fb4cbc5. * fix(docs): build failure for changing to ssr * fix(docs): build failure for changing to ssr * fix(ci): resolve broken tests after delayed rendering * fix(ci): resolve broken tests after delayed rendering --------- Co-authored-by: Shoaib Ahmed <ashoaib540918@gmail.com> Co-authored-by: kodiakhq[bot] <49736102+kodiakhq[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.