Skip to content

feat(corner-ornament): adds new component for corner ornament #4009

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 72 commits into from
Aug 6, 2024
Merged

feat(corner-ornament): adds new component for corner ornament #4009

merged 72 commits into from
Aug 6, 2024

Conversation

krisantrobus
Copy link
Collaborator

@krisantrobus krisantrobus commented Jul 29, 2024 •
edited
Loading

This pull request introduces a new CornerOrnament component to the @twilio-paste/core library. The changes include the creation of the component, its context, and associated elements, as well as updates to various configuration and test files to integrate the new component.

New components added:

  • CornerOrnamentContainer
  • CornerOrnamentBase
  • CornerOrnament
  • CornerOrnamentContext

Testing:
Unit Tests: Added unit tests for the CornerOrnament component. (packages/paste-core/components/corner-ornament/tests/index.spec.tsx)

@bolt-new-by-stackblitz Bolt.new (by StackBlitz)
Copy link

Review PR in StackBlitz Codeflow Run & review this pull request in StackBlitz Codeflow.

@changeset-bot changeset-bot
Copy link

changeset-bot bot commented Jul 29, 2024 •
edited
Loading

🦋 Changeset detected

Latest commit: 96d2ad5

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 6 packages
Name Type
@twilio-paste/core Minor
@twilio-paste/design-tokens Minor
@twilio-paste/icons Minor
@twilio-paste/codemods Minor
@twilio-paste/corner-ornament Major
@twilio-paste/website Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@vercel Vercel
Copy link

vercel bot commented Jul 29, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
paste-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Aug 6, 2024 4:48pm
paste-remix ✅ Ready (Inspect) Visit Preview 💬 Add feedback Aug 6, 2024 4:48pm

@dosubot dosubot bot added the size:XL This PR changes 500-999 lines, ignoring generated files. label Jul 29, 2024
@krisantrobus krisantrobus marked this pull request as draft July 29, 2024 15:02
@github-actions github-actions bot added the Status: Do Not Merge This PR is not yet ready to be merged back into the main branch label Jul 29, 2024
@github-actions github-actions bot added Area: Components Related to the component library (core) of this system Type: Tests Adds tests to the code Area: Repo Area: Core bundle labels Jul 29, 2024
@dosubot dosubot bot added size:XXL This PR changes 1000+ lines, ignoring generated files. and removed size:XL This PR changes 500-999 lines, ignoring generated files. labels Aug 5, 2024
@serifluous
Copy link
Member

Ok! Yes the smaller sizes of Avatar + Badge do look a little odd. It's a little bit intentional because Icon + Badge are probably more likely to be paired together, and the spacing as spec'd looks a bit better with Icon than Avatar:

Screenshot 2024-08-05 at 4 12 49 PM

But let's monitor as this gets used in the product because we could shift the Badge a few pixels closer later on if we need to.

serifluous
serifluous previously approved these changes Aug 5, 2024
View reviewed changes
@dosubot dosubot bot added the lgtm This PR has been approved by a maintainer label Aug 5, 2024
@krisantrobus krisantrobus added the 🕵🏻‍♀️ Run website visual regression When applied, we will run a full suite of visual regression tests across the doc site label Aug 6, 2024
@cypress Cypress
Copy link

cypress bot commented Aug 6, 2024 •
edited
Loading


Test summary

125 • 0 • 0 • 0 • Flakiness 0

Run details
Project Paste
Status Passed
Commit 8a1b841 ℹ️
Started Aug 6, 2024 4:44 PM
Ended Aug 6, 2024 4:51 PM
Duration 06:43 💡
OS Linux Ubuntu - 22.04
Browser Electron 102

View run in Cypress Cloud ➡️

This comment has been generated by cypress-bot as a result of this project's GitHub integration settings. You can manage this integration in this project's settings in the Cypress Cloud

@krisantrobus krisantrobus added 🚀 merge it! and removed Status: Do Not Merge This PR is not yet ready to be merged back into the main branch labels Aug 6, 2024
@kodiakhq kodiakhq bot merged commit d3d74e5 into main Aug 6, 2024
43 of 44 checks passed
@kodiakhq kodiakhq bot deleted the feat/corner-onament branch August 6, 2024 17:02
@TwilioPasteBot TwilioPasteBot mentioned this pull request Aug 6, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nkrantz nkrantz nkrantz left review comments

@serifluous serifluous serifluous approved these changes

Assignees

@krisantrobus krisantrobus

Labels
Area: Components Related to the component library (core) of this system Area: Core bundle Area: Primitives Area: Repo Area: Tokens Comments and questions related to tokens lgtm This PR has been approved by a maintainer 🚀 merge it! 🕵🏻‍♀️ Run website visual regression When applied, we will run a full suite of visual regression tests across the doc site size:XXL This PR changes 1000+ lines, ignoring generated files. Type: Tests Adds tests to the code
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@krisantrobus @serifluous @nkrantz