Skip to content

feat(corner-onament): add new component for corner oranment #4008

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 11 commits into from

Conversation

krisantrobus
Copy link
Collaborator

This pull request introduces a new CornerOrnament component to the @twilio-paste/core library. The changes include the creation of the component, its context, and associated elements, as well as updates to various configuration and test files to integrate the new component.

New components added:

  • CornerOrnamentContainer
  • CornerOrnamentElement
  • CornerOrnament
  • CornerOrnamentContext

Testing:

  • Unit Tests: Added unit tests for the CornerOrnament component. (packages/paste-core/components/corner-ornament/__tests__/index.spec.tsx)

Copy link

Review PR in StackBlitz Codeflow Run & review this pull request in StackBlitz Codeflow.

Copy link

vercel bot commented Jul 29, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
paste-docs ❌ Failed (Inspect) Jul 29, 2024 3:00pm
paste-remix ❌ Failed (Inspect) Jul 29, 2024 3:00pm

Copy link

changeset-bot bot commented Jul 29, 2024

🦋 Changeset detected

Latest commit: 4bc5d3c

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 2 packages
Name Type
@twilio-paste/corner-ornament Major
@twilio-paste/core Minor

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@dosubot dosubot bot added the size:XL This PR changes 500-999 lines, ignoring generated files. label Jul 29, 2024
@github-actions github-actions bot added the Status: Do Not Merge This PR is not yet ready to be merged back into the main branch label Jul 29, 2024
@github-actions github-actions bot added Area: Components Related to the component library (core) of this system Type: Tests Adds tests to the code Area: Repo Area: Core bundle labels Jul 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area: Components Related to the component library (core) of this system Area: Core bundle Area: Repo size:XL This PR changes 500-999 lines, ignoring generated files. Status: Do Not Merge This PR is not yet ready to be merged back into the main branch Type: Tests Adds tests to the code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant