chore(collaboration): added script to resolve typedoc issue #3997
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
|
dosubot
bot
added
the
size:XS
github-actions
bot
added
the
Status: Do Not Merge
☁️ Nx Cloud ReportCI is running/has finished running commands for commit 7ce602c. As they complete they will appear below. Click to see the status, the terminal output, and the build insights. 📂 See all runs for this CI Pipeline Execution ✅ Successfully ran 1 targetSent with 💌 from NxCloud. |
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit 7ce602c:
|
|
Size Change: 0 B Total Size: 1.08 MB ℹ️ View Unchanged
|
Passing run #8322 ↗︎
Details:
Review all test suite changes for PR #3997 ↗︎ |
|||||||||||||||
nkrantz
approved these changes
Jul 23, 2024
krisantrobus
added
the
🕵🏻♀️ Run website visual regression
Passing run #8321 ↗︎
Details:
Review all test suite changes for PR #3997 ↗︎ |
|||||||||||||||
krisantrobus
added
🚀 merge it!
and removed
Status: Do Not Merge
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added a new script into package.json to run a series of commands to resolve the typedoc issue when forking the repo.
After investigation I found that if you run the typedoc command before running the build command it will output incorrect typedocs and cause large unintended and incorrect changes to various typedoc files. What is more interesting is that these incorrect changes are different per machine.
The resolution is to clean the local NX cache and run the full build and typedocs scrips. Tested locally by forking the repo multiple times.
If we see this issue in collab PRs we can now ask them to just run this to resolve the issue instead of granting write access to our repo