-
Notifications
You must be signed in to change notification settings - Fork 119
chore(docs/chat-composer): Update the documentation for the new Chat Composer elements #3981
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
🦋 Changeset detectedLatest commit: 8b24cdc The changes in this PR will be included in the next version bump. This PR includes changesets to release 2 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
☁️ Nx Cloud ReportCI is running/has finished running commands for commit 8b24cdc. As they complete they will appear below. Click to see the status, the terminal output, and the build insights. 📂 See all runs for this CI Pipeline Execution ✅ Successfully ran 1 targetSent with 💌 from NxCloud. |
export const SendButtonPlugin = ({ onClick }: { onClick: () => void }): JSX.Element => { | ||
const [editor] = useLexicalComposerContext(); | ||
|
||
const handleSend = (): void => { | ||
onClick(); | ||
editor.dispatchCommand(CLEAR_EDITOR_COMMAND, undefined); | ||
}; | ||
|
||
return ( | ||
<Box position="absolute" top="space30" right="space30"> | ||
<Button variant="primary_icon" size="reset" onClick={handleSend}> | ||
<SendIcon decorative={false} title="Send message" /> | ||
</Button> | ||
</Box> | ||
); | ||
}; | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This was used as an example of putting the button inside the text area which we want to avoid.
Co-authored-by: Sarah <sali@twilio.com>
packages/paste-website/src/pages/components/chat-composer/index.mdx
Outdated
Show resolved
Hide resolved
packages/paste-website/src/pages/components/chat-composer/index.mdx
Outdated
Show resolved
Hide resolved
…o docs/chat-composer
…x.mdx Co-authored-by: Sarah <sali@twilio.com>
Passing run #8229 ↗︎Details:
Review all test suite changes for PR #3981 ↗︎ |
"@twilio-paste/core": patch | ||
--- | ||
|
||
[ChatComposer] updated JS Doc used for tpye gen in docs website |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
suggestion(non-blocking): no change required here, just a little tip for future changelogs, I like to be super specific to let our consumers know why we change certain files, like specifying that it was just a typo fix to a prop description
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Super clean docs and Chat Composer ended up in a really great spot 🔥
Extended docs to include the new component elements along with examples.