-
Notifications
You must be signed in to change notification settings - Fork 119
feat(ai-chat-log): Adding docs for new component #3963
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
…paste into docs/ai-logs
<ThumbsDownIcon decorative={false} title="dislike result" /> | ||
</Button> | ||
</AIChatMessageActionCard> | ||
<AIChatMessageActionCard> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
suggestion: I think I added some aria labels to the rewrite button and maybe also the thumbs up/down buttons in the stories - can you copy whatever I did there for the action card sections in these examples?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great catch. I will address this in the next commit
}} | ||
language="jsx" | ||
> | ||
{`<AIChatLog> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
question (non-blocking): just curious, nothing wrong with it, but why are you writing this example out here and importing the others?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The first LivePreview in the chat-log index page did the same. Seeing a trend for simpler components while looking through other doc pages not being put in examples.
I open to changing this if we want to start a best practice on it
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Makes sense, no need to change :)
@@ -292,7 +292,7 @@ This example combines all the separate features displayed previously into one ex | |||
|
|||
The `useChatLogger` hook provides a hook based approach to managing chat state. It is best used with the `<ChatLogger />` component. | |||
|
|||
`useChatLogger` returns 3 things: | |||
`useChatLogger` returns 4 things: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🤣 good catch
language="jsx" | ||
noInline | ||
> | ||
{botWithBodyActions} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Absolutely!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
So good!! Can you add a little section to explain the props for ChatMessageAuthor to change the content of the avatar?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
packages/paste-website/src/pages/components/ai-chat-log/index.mdx
Outdated
Show resolved
Hide resolved
packages/paste-website/src/pages/components/ai-chat-log/index.mdx
Outdated
Show resolved
Hide resolved
packages/paste-website/src/pages/components/ai-chat-log/index.mdx
Outdated
Show resolved
Hide resolved
Co-authored-by: Sarah <sali@twilio.com>
Passing run #8153 ↗︎Details:
Review all test suite changes for PR #3963 ↗︎ |
Added new docs page for
ai-chat-log