Skip to content

feat(combobox): make the title collapsible #3950

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 4 commits into from

Conversation

YiyangLi
Copy link

Hi, I want to add a feature to combox, specifically making the group label collapsible. We are not able to use groupLabelTemplate to simply add an interactive button. Because we are not able to "hide" the children items under the group.

Contributing to Twilio

All third-party contributors acknowledge that any contributions they provide will be made under the same open-source license that the open-source project is provided under.

  • I acknowledge that all my contributions will be made under the project's license.

Copy link

Review PR in StackBlitz Codeflow Run & review this pull request in StackBlitz Codeflow.

Copy link

changeset-bot bot commented Jun 18, 2024

🦋 Changeset detected

Latest commit: 736804b

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 3 packages
Name Type
@twilio-paste/combobox Major
@twilio-paste/core Patch
@twilio-paste/website Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link

vercel bot commented Jun 18, 2024

Someone is attempting to deploy a commit to the Twilio Team on Vercel.

A member of the Team first needs to authorize it.

@dosubot dosubot bot added the size:L This PR changes 100-499 lines, ignoring generated files. label Jun 18, 2024
@YiyangLi
Copy link
Author

Screenshot 2024-06-18 at 2 13 24 PM

Copy link

codesandbox-ci bot commented Jun 18, 2024

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 736804b:

Sandbox Source
@twilio-paste/nextjs-template Configuration
@twilio-paste/token-contrast-checker Configuration

Copy link

nx-cloud bot commented Jun 20, 2024

☁️ Nx Cloud Report

CI is running/has finished running commands for commit 00bbcdc. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this CI Pipeline Execution


✅ Successfully ran 1 target

Sent with 💌 from NxCloud.

@nkrantz nkrantz marked this pull request as draft June 20, 2024 13:13
@serifluous serifluous added the Contribution This is a contribution label Jul 3, 2024
@nkrantz
Copy link
Collaborator

nkrantz commented Jul 10, 2024

Update: after speaking with the team and with @YiyangLi we've decided to close this PR for now. DSYS doesn't have the capacity to facilitate non-roadmap contributions at the moment, but we'll reassess this contribution when we have more capacity.

@nkrantz nkrantz closed this Jul 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Contribution This is a contribution size:L This PR changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants