-
Notifications
You must be signed in to change notification settings - Fork 119
on-confirm-disabled-rename #3918
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
🦋 Changeset detectedLatest commit: 3ecad2d The changes in this PR will be included in the next version bump. This PR includes changesets to release 2 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
☁️ Nx Cloud ReportCI is running/has finished running commands for commit 3ecad2d. As they complete they will appear below. Click to see the status, the terminal output, and the build insights. 📂 See all runs for this CI Pipeline Execution ✅ Successfully ran 3 targetsSent with 💌 from NxCloud. |
Size Change: +18 B (0%) Total Size: 1.05 MB
ℹ️ View Unchanged
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. |
Passing run #8072 ↗︎Details:
Review all test suite changes for PR #3918 ↗︎ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for this improvement and for branching in the repo!
Passing run #8074 ↗︎Details:
Review all test suite changes for PR #3918 ↗︎ |
Renaming the onConfirmDisabled property in AlertDialog to be isConfirmDisabled so that the property is more transparent how it should be used. onConfirmDisabled reads more like it expects a function. isConfirmDisabled reads more like it expects a boolean. #3901
Contributing to Twilio