-
Notifications
You must be signed in to change notification settings - Fork 119
chore(Input): increment/decrement reset buttons focus stylings #3917
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
7 commits
Select commit
Hold shift + click to select a range
76cd29a
feat(Intput): increment/decrement reset buttons focus stylings
krisantrobus 39ba2a7
feat(Input): updating the changeset to include core patch
krisantrobus 520967f
feat(Input): lint fix
krisantrobus 9cf682c
feat(Input): destructure prop
krisantrobus 6b817ed
chore(Input): use box shaow instead of border
krisantrobus 75f75db
Merge branch 'main' of github.com:twilio-labs/paste into input/reset-…
krisantrobus be939a0
Merge branch 'main' of github.com:twilio-labs/paste into input/reset-…
krisantrobus File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,6 @@ | ||
--- | ||
"@twilio-paste/input": patch | ||
"@twilio-paste/core": patch | ||
--- | ||
|
||
[Input] updated focus stylings on increment/decrement buttons for number input type on both default and inverse variants | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -713,6 +713,32 @@ export const DefaultNumberInput = (): React.ReactNode => { | |
|
||
DefaultNumberInput.storyName = "Number Input - Controlled"; | ||
|
||
export const DefaultNumberInverseInput = (): React.ReactNode => { | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. praise: new story for this missed use case 👏 |
||
const uid = useUID(); | ||
const [value, setValue] = React.useState("0"); | ||
return ( | ||
<Box backgroundColor="colorBackgroundBodyInverse" padding="space60"> | ||
<Label htmlFor={uid} variant="inverse"> | ||
Label | ||
</Label> | ||
<Input | ||
id={uid} | ||
type="number" | ||
max="50" | ||
min="-50" | ||
step={5} | ||
value={value} | ||
onChange={(event) => { | ||
setValue(event.target.value); | ||
}} | ||
variant="inverse" | ||
/> | ||
</Box> | ||
); | ||
}; | ||
|
||
DefaultNumberInverseInput.storyName = "Number Input - Inverse Controlled"; | ||
|
||
export const TestNumberInput = (): React.ReactNode => { | ||
const uid = useUID(); | ||
const [value, setValue] = React.useState("5"); | ||
|
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.