add support for function/asset upload #31
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| export const uploadAssetAPI: API = { | ||
| method: 'POST', | ||
| contentType: 'multipart/form-data', | ||
| path: 'fake', |
There was a problem hiding this comment.
will there be conflicting asset names here if it makes more than one in a session for the same service?
There was a problem hiding this comment.
This is just a stub because we need an apis inside the server during the lookup (they are used for making the HTTP call) but for upload, we have hand-written upload method so the apis is unused. But I still have to define this stub other we get a Tool not found
vingiarrusso
approved these changes
May 16, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Contributing to Twilio