Use E.164 format by default for phone numbers #595
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
robinske
force-pushed
the
passkeys-tel-input
branch
from
65b2b11 to
d6f47f1
Compare
bnb
approved these changes
Jun 3, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The code was ignoring the country code, this fix sends the E.164 formatted number to the backend and fixes some of the formatting.
Main change is here: https://github.com/twilio-labs/function-templates/pull/595/files#diff-1337e4517fafaf1ecc4e4ba959494bf3e9b59953f244d178e7c0842119666abfR281
The rest is formatting updates!
Checklist
npm testlocally and it passed without errors.Related issues