Skip to content

Cleaning up OTP project for code exchange #534

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jul 23, 2024
Merged

Cleaning up OTP project for code exchange #534

merged 2 commits into from
Jul 23, 2024

Conversation

robinske
Copy link
Collaborator

…nsole, cleaned up code

Description

Worked with @rishabkumar7 to update this project

  • bumped twilio-node dependency
  • delegated channel enabling back to console
  • cleaned up code

Checklist

  • I ran npm test locally and it passed without errors.
  • I acknowledge that all my contributions will be made under the project's license.

Related issues

@robinske robinske requested a review from cmsunu28 June 28, 2024 15:02
@cmsunu28
Copy link
Contributor

Hey Kelley! Can you add some comments to the sample code so that a naive user could understand what the code is doing? Example: https://github.com/twilio-labs/function-templates/blob/main/funlet-find-me/functions/funlet-find-me.protected.js

@robinske
Copy link
Collaborator Author

@cmsunu28 done!

@robinske robinske merged commit 43a18d5 into main Jul 23, 2024
2 checks passed
@robinske robinske deleted the update-verify-otp branch July 23, 2024 14:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants