Skip to content

feat(templates): add passkeys-backend template #531

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 17 commits into from
Jul 10, 2024

Conversation

nicolas-camacho
Copy link
Contributor

Description

Quick deploy template for a sample backend for passkeys using comms API .

Let me know any suggestions or feedback you might have.

Live demo at: https://passkey-demo-5706.twil.io/index.html

Checklist

  • I ran npm test locally and it passed without errors.
  • I acknowledge that all my contributions will be made under the project's license.

@nicolas-camacho nicolas-camacho changed the title feat(templates): add passkeys sample backend template feat(templates): add passkeys-backend template Jun 20, 2024
Copy link
Collaborator

@robinske robinske left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For consistency, let's point people to use webauthn-json instead of writing their own array buffer conversion functions. Here's how I did that if it's useful

Otherwise, I tested locally on web and it works great, I'm going to use this for the demo application!

@nicolas-camacho nicolas-camacho requested a review from robinske June 24, 2024 10:22
@cmsunu28
Copy link
Contributor

@nicolas-camacho It looks like we're also having some test failure with this template--
CI template verification › the "passkeys-backend" function template › its .env.example (or .env) file and webhooks › should have a description for each variable
Can you take a look at this and see what you can do? Thank you!

@robinske
Copy link
Collaborator

@nicolas-camacho left a few more comments - let me know when you want me to take another look!

@nicolas-camacho nicolas-camacho requested a review from robinske June 27, 2024 10:30
Copy link
Collaborator

@robinske robinske left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

just a couple more things! thanks @nicolas-camacho !

@cmsunu28
Copy link
Contributor

Hi all. Still getting failures on the tests unfortunately.

@nicolas-camacho nicolas-camacho requested a review from robinske July 9, 2024 13:13
@robinske
Copy link
Collaborator

robinske commented Jul 9, 2024

LGTM 👍🏻

@cmsunu28 cmsunu28 merged commit b87b2ec into twilio-labs:main Jul 10, 2024
2 checks passed
Copy link

welcome bot commented Jul 10, 2024

Congratulations on your first contribution to the Twilio Function Templates!
If you are on the look out for more ways to contribute to open-source, check out a list of some of our repositories at https://github.com/twilio/opensource.
To stay up-to-date with Twilio open source related updates, sign up here: https://twil.io/oss-updates
And if you love Twilio as much as we do, make sure to check out our Twilio Champions program!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants