Skip to content

ci: clean up the Node.js CI GitHub Action #528

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 17, 2024
Merged

ci: clean up the Node.js CI GitHub Action #528

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
44 changes: 14 additions & 30 deletions .github/workflows/nodejs.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
name: Node.js CI
name: Build, Test, Lint, Format (Node.js)

on: [pull_request]

Expand All @@ -16,42 +16,26 @@ jobs:
uses: actions/setup-node@v3
with:
node-version: ${{ matrix.node-version }}
# - name: Cache node modules
# uses: actions/cache@v1
# with:
# path: node_modules
# key: ${{ matrix.os }}-${{ matrix.node-version }}-build-${{ hashFiles('**/package-lock.json') }}
# restore-keys: |
# ${{ matrix.os }}-${{ matrix.node-version }}-build-${{ env.cache-name }}-
# ${{ matrix.os }}-${{ matrix.node-version }}-build-
# ${{ matrix.os }}-${{ matrix.node-version }}-
# - name: Cache Cypress
# uses: actions/cache@v1
# with:
# path: /home/runner/.cache/Cypress
# key: ${{ matrix.os }}-${{ matrix.node-version }}-cypress-${{ hashFiles('**/package-lock.json') }}
# restore-keys: |
# ${{ matrix.os }}-${{ matrix.node-version }}-cypress-${{ env.cache-name }}-
# ${{ matrix.os }}-${{ matrix.node-version }}-cypress-
# ${{ matrix.os }}-${{ matrix.node-version }}-
- name: install latest npm
run: |
npm install -g npm@latest
- name: npm install, build, and test
run: |
npm install
npm run build --if-present
npm test
run: npm install -g npm@latest
- name: npm install
run: npm install
env:
CI: true
- name: check formatting
if: always()
- name: npm run build --if-present
run: npm run build --if-present
env:
CI: true
- name: npm test
run: npm test
env:
CI: true
- name: npm run format:check
run: npm run format:check
env:
CI: true
NODE_ENV: test
- name: lint
if: always()
- name: npm run lint
run: npm run lint
env:
CI: true
Loading