-
-
Notifications
You must be signed in to change notification settings - Fork 79.1k
docs(pagination): put current page on link element for a11y #41154
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
@patrickhlauke Mind giving your guidance here? |
only partially agree here. yes, however, it's the author's choice whether or not they want to have the current page's pagination as an active link or not. it's perfectly valid to decide not to make the current page's indicator a link at all. at that point, you can also omit the |
Hello @patrickhlauke and @mdo, thank you for the replies :) Indeed it's the author's choice to put the pagination elements as link or not. The idea here is to provide an accessible example in Bootstrap that is aligned with major SRs (JAWS, NVDA) so that by default their code is a11y compliant. |
Slating for v5.4.0 for me to revisit. This will need a rebase to bring it up to speed with the move to `.mdx. |
dcbdb96
to
47896df
Compare
47896df
to
ca64e71
Compare
Hello, @mdo , PR rebased and aligned with |
Wonderful! Pushed some copy edits to make the examples and optional span/a swap a little clearer. Re-slating for v5.3.6. |
coming back in late to say: a page that chooses not to make the marker for the current page an actionable element is not somehow "non-compliant" |
Description
Update the Pagination examples to have the
aria-current="page"
on the link elements.Modify the part where the
active
pagination element can be replaced with span.Motivation & Context
Focusable pagination element should be marked with aria-current for the SR to read it properly (NVDA works with the attribute set on li but JAWS needs it to be on element).
Active pagination element should not be a span as assistive technology won't read it as active page.
reference of the aria-current and recommended usage:
Type of changes
Checklist
npm run lint
)Live previews
Related issues