Docs: Improve label of copy/stackblitz buttons for accessibility #40820
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…xample with Accordion
…xample with Accordion and Alerts
10 tasks
75 tasks
…-a11y' into main-his-stackblitz-copy-buttons-a11y
|
Is this strictly necessary? Feels like this is going to be a lot, and I'm concerned it also will put a strain on work with #41251 and more. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Added discriminating information to the label of the "Edit in Stackblitz" and "Copy to clipboard" buttons of examples, to know exactly what they correspond to.
This is a first version to validate the principle, with an example on Accordion component, before doing it everywhere (huge work).
I also have to check if it is possible to propose something for the copy buttons outside of the example shortcode (like in Getting started) which are not implemented the same way.
Motivation & Context
All "Edit in Stackblitz" and "Copy to clipboard" buttons had the same labels, making it impossible to do the difference between the examples.
Type of changes
Checklist
npm run lint)Live previews
Related issues
Asked while discussing in #40766