Skip to content

[PROTO] Add dynamic position for alert button close #38588

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

julien-deramond
Copy link
Member

@julien-deramond julien-deramond commented May 11, 2023

⚠️ Don't merge this PR! This is a prototype for now

Description

This PR, for now, prototypes what's mentioned in #38587 with the idea of having a 5px padding for the alert close button (minimal padding for visible focus) and then positioning it dynamically based on custom padding x and y properties.

Type of changes

  • Refactoring (non-breaking change)

Checklist

  • I have read the contributing guidelines
  • My code follows the code style of the project (using npm run lint)
  • My change introduces changes to the documentation
  • (N/A) I have updated the documentation accordingly
  • (N/A) I have added tests to cover my changes
  • All new and existing tests passed

Live previews

Temporary examples in https://deploy-preview-38588--twbs-bootstrap.netlify.app/docs/5.3/components/alerts/#dismissing

Related issues

Closes #38587

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

The CSS properties to control the padding for dismissible Alerts is not working
1 participant