-
-
Notifications
You must be signed in to change notification settings - Fork 79.1k
Transitions animations #38296
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Transitions animations #38296
Conversation
f186982
to
6e5ea94
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Feel like these should be generated with the utility API and as helpers as they are single property-value pairs.
Hi @mdo , thank you for your comment. |
Don't worry about the failed Bundlewatch test. The difference is not that important, we can still increase the limit when the review will be over. |
Description
This pull request adds modifier classes in helpers/animations.scss (new file). These classes are as follows:
These classes are there to alter the animation behavior (direction) of any component, such as spinners.
Motivation & Context
This PR comes as a first step to solving #38150 . Another PR (#38167) introduced an alternative solution by @oraliahdz .
Type of changes
Checklist
npm run lint
)Live previews
https://deploy-preview-38296--twbs-bootstrap.netlify.app/docs/5.3/helpers/animations/
Related issues
Fixes #38150