Skip to content

Fixed form switch when enable-rounded is false #38277

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

maciek-szn
Copy link
Contributor

@maciek-szn maciek-szn commented Mar 19, 2023

Description

Different approach to #38109. When enable-rounded is set to false switch indicator shouldn't be rounded.

Motivation & Context

When enable-rounded is set to false form switch component takes the form of a retangle with rounded corners removed. However the switch indicator is still a circle, which is not consistent.

obraz

After the fix the switch indicator will be a rectangle.

obraz

Type of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Refactoring (non-breaking change)
  • Breaking change (fix or feature that would change existing functionality)

Checklist

  • I have read the contributing guidelines
  • My code follows the code style of the project (using npm run lint)
  • My change introduces changes to the documentation
  • I have updated the documentation accordingly
  • I have added tests to cover my changes
  • All new and existing tests passed

Related issues

#38109

@maciek-szn maciek-szn requested a review from a team as a code owner March 19, 2023 09:57
@maciek-szn maciek-szn marked this pull request as draft March 19, 2023 10:04
@maciek-szn maciek-szn marked this pull request as ready for review March 19, 2023 10:29
@gregorw gregorw mentioned this pull request Mar 19, 2023
10 tasks
@gregorw
Copy link

gregorw commented Mar 22, 2023

@maciek-szn I have updated my PR (#38109) pretty much at the same time as you proposed this one. I also did a demo app:
https://gregorw.github.io/bootstrap-switch-bugfix/

Would you mind closing your PR such that I can get my first contribution to this repository? I’d love to be a contributor to Bootstrap.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants