Skip to content

Support different line heights for buttons. #38062

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

LunicLynx
Copy link

@LunicLynx LunicLynx commented Feb 15, 2023

Description

Buttons of different sizes should also support different line heights.

Motivation & Context

When configuring a custom style it is required to also adjust the line height for different size buttons.

Type of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Refactoring (non-breaking change)
  • Breaking change (fix or feature that would change existing functionality)

Checklist

  • I have read the contributing guidelines
  • My code follows the code style of the project (using npm run lint)
  • My change introduces changes to the documentation
  • I have updated the documentation accordingly
  • I have added tests to cover my changes
  • All new and existing tests passed

Live previews

@LunicLynx LunicLynx requested a review from a team as a code owner February 15, 2023 15:01
@LunicLynx
Copy link
Author

Maybe this should also be done for control sizes as well.

@julien-deramond
Copy link
Member

Thanks for this PR @LunicLynx. We'll try to look into it asap.
Just for info for the possible reviewers, Boosted (fork of Bootstrap) has the same approach to handle the line height: new parameter in button-size() mixin + $btn-line-height-lg and $btn-line-height-sm.

@LunicLynx LunicLynx force-pushed the support-different-line-height-for-buttons branch 2 times, most recently from a8faa41 to da39961 Compare February 15, 2023 18:32
@LunicLynx LunicLynx force-pushed the support-different-line-height-for-buttons branch from da39961 to 257d7ce Compare February 15, 2023 18:47
@mdo mdo added this to v5.4.0 Apr 9, 2025
@github-project-automation github-project-automation bot moved this to Needs review in v5.4.0 Apr 9, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Status: Needs review
Development

Successfully merging this pull request may close these issues.

3 participants