-
-
Notifications
You must be signed in to change notification settings - Fork 19
Enhance Request Feature #3142
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Enhance Request Feature #3142
Changes from 8 commits
Commits
Show all changes
16 commits
Select commit
Hold shift + click to select a range
80fe900
feat: revise feature access API to accompany more features
VNOsST f6a68b5
Merge branch 'main' into feat/enhanced-requests-feature
VNOsST cd739d3
feat: enhance request route to work with multiple secrets
VNOsST 531e026
feat: refactor requestable features
VNOsST d62d59c
fix: build errors
VNOsST cc6eb3f
feat: allow feature approvals to be modular
VNOsST 34eef7a
style: apply prettier formatting
VNOsST f9b1887
style: apply prettier formatting for feat/enhanced-requests-feature (…
VNOsST dcea340
feat: implement coderabbit suggestions
VNOsST e4b9a1a
Merge branch 'main' into feat/enhanced-requests-feature
VNOsST 76feef4
feat: add translations
VNOsST ce475d9
feat: revised banner
VNOsST b6fc58a
fix: build errors
VNOsST b08589d
style: apply prettier formatting
VNOsST 05b4bd7
style: apply prettier formatting for feat/enhanced-requests-feature (…
VNOsST a281932
feat: add initial feature flags and update database schema
vhpx File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,9 @@ | ||
create type "public"."FEATURE_FLAG" as enum ('ENABLE_AI', 'ENABLE_EDUCATION', 'ENABLE_CHALLENGES', 'ENABLE_QUIZZES'); | ||
|
||
drop index if exists "public"."workspace_education_access_requests_unique_pending"; | ||
|
||
alter table "public"."workspace_education_access_requests" add column "feature" "FEATURE_FLAG" not null default 'ENABLE_EDUCATION'::"FEATURE_FLAG"; | ||
|
||
CREATE UNIQUE INDEX workspace_education_access_requests_unique_pending ON public.workspace_education_access_requests USING btree (ws_id, feature) WHERE (status = 'pending'::text); | ||
|
||
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
59 changes: 59 additions & 0 deletions
59
...kii/src/app/[locale]/(dashboard)/[wsId]/(workspace-settings)/approvals/feature-filter.tsx
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,59 @@ | ||
'use client'; | ||
|
||
import { | ||
Select, | ||
SelectContent, | ||
SelectItem, | ||
SelectTrigger, | ||
SelectValue, | ||
} from '@tuturuuu/ui/select'; | ||
import { | ||
getRequestableFeature, | ||
getRequestableFeatureKeys, | ||
} from '@tuturuuu/utils/feature-flags/requestable-features'; | ||
import { useRouter, useSearchParams } from 'next/navigation'; | ||
|
||
interface FeatureFilterProps { | ||
currentFeature?: string; | ||
} | ||
|
||
export function FeatureFilter({ currentFeature }: FeatureFilterProps) { | ||
const router = useRouter(); | ||
const searchParams = useSearchParams(); | ||
|
||
const handleFeatureChange = (feature: string) => { | ||
const params = new URLSearchParams(searchParams); | ||
|
||
if (feature === 'all') { | ||
params.delete('feature'); | ||
} else { | ||
params.set('feature', feature); | ||
} | ||
|
||
// Reset to first page when filtering | ||
params.delete('page'); | ||
|
||
router.push(`?${params.toString()}`); | ||
}; | ||
|
||
const availableFeatures = getRequestableFeatureKeys(); | ||
|
||
return ( | ||
<Select value={currentFeature || 'all'} onValueChange={handleFeatureChange}> | ||
<SelectTrigger className="w-[180px]"> | ||
<SelectValue placeholder="Filter by feature" /> | ||
</SelectTrigger> | ||
<SelectContent> | ||
<SelectItem value="all">All Features</SelectItem> | ||
{availableFeatures.map((featureKey) => { | ||
const feature = getRequestableFeature(featureKey); | ||
return ( | ||
<SelectItem key={featureKey} value={featureKey}> | ||
{feature.name} | ||
</SelectItem> | ||
); | ||
})} | ||
</SelectContent> | ||
</Select> | ||
); | ||
} | ||
Check warning on line 59 in apps/upskii/src/app/[locale]/(dashboard)/[wsId]/(workspace-settings)/approvals/feature-filter.tsx
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.