chore: production payment setup #3128
Conversation
How to use the Graphite Merge QueueAdd either label to this PR to merge it via the merge queue:
You must have a Graphite account in order to use the merge queue. Sign up using this link. An organization admin has enabled the Graphite Merge Queue in this repository. Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue. |
WalkthroughThe changes update environment-based configuration for external service endpoints and icon imports. The Polar API client and webhook logic now select between sandbox and production servers based on the environment. The payment route dynamically sets URLs and removes an unused field. Icon imports in the billing client are switched to an external library. Changes
Sequence Diagram(s)sequenceDiagram
participant Client
participant API_Route
participant PolarAPI
Client->>API_Route: Initiate payment request
API_Route->>API_Route: Determine environment (dev/prod)
API_Route->>API_Route: Set BASE_URL accordingly
API_Route->>PolarAPI: Create checkout session with dynamic successUrl
PolarAPI-->>API_Route: Respond with session info
API_Route-->>Client: Return checkout session response
Suggested labels
Poem
Warning There were issues while running some tools. Please review the errors and either fix the tool's configuration or disable the tool if it's a critical failure. 🔧 ESLint
apps/web/src/app/api/[wsId]/[productId]/payment/route.tsOops! Something went wrong! :( ESLint: 9.29.0 Error [ERR_MODULE_NOT_FOUND]: Cannot find package '@typescript-eslint/parser' imported from /eslint.config.mjs 📜 Recent review detailsConfiguration used: CodeRabbit UI 📒 Files selected for processing (1)
🧰 Additional context used🪛 GitHub Check: codecov/patchapps/web/src/app/api/[wsId]/[productId]/payment/route.ts[warning] 10-14: apps/web/src/app/api/[wsId]/[productId]/payment/route.ts#L10-L14 [warning] 67-68: apps/web/src/app/api/[wsId]/[productId]/payment/route.ts#L67-L68 ⏰ Context from checks skipped due to timeout of 90000ms (8)
🔇 Additional comments (1)
✨ Finishing Touches
🧪 Generate Unit Tests
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Create a ticket on our support page for assistance with any issues or questions. Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Summary of Changes
Hello @phatgg221, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!
This pull request primarily focuses on adapting the payment integration to work correctly across development and production environments. It introduces environment-aware configurations for the Polar payment gateway, ensuring that the correct server mode and success URLs are used based on the deployment environment. Additionally, it includes a minor update to the icon library used in the billing client.
Highlights
- Environment-aware Payment Configuration: Configured the Polar payment API clients (
polarAdminandapi) and webhooks to dynamically switch between 'sandbox' and 'production' server modes based on theNODE_ENVenvironment variable. - Dynamic Success URL Handling: Introduced
DEV_MODE,PROD_MODE, andBASE_URLconstants in the payment route. TheBASE_URLis now used to construct thesuccessUrlfor Polar checkout sessions, ensuring correct redirects tohttp://localhost:7803in development andhttps://tuturuuu.comin production. - Payment Customer ID Adjustment: The
externalCustomerIdparameter has been commented out when creating Polar checkout sessions in the payment route. - Icon Library Update: Switched the icon import in
billing-client.tsxfrom@tuturuuu/ui/iconstolucide-react.
Using Gemini Code Assist
The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.
Invoking Gemini
You can request assistance from Gemini at any point in your pull request via creating an issue comment (i.e. comment on the pull request page) using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands.
| Feature | Command | Description |
|---|---|---|
| Code Review | /gemini review |
Performs a code review for the current pull request in its current state. |
| Pull Request Summary | /gemini summary |
Provides a summary of the current pull request in its current state. |
| Comment | @gemini-code-assist | Responds in comments when explicitly tagged, both in issue comments and review comments. |
| Help | /gemini help |
Displays a list of available commands. |
Customization
To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.
Limitations & Feedback
Gemini Code Assist is currently in preview and may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments to provide feedback.
You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.
Footnotes
-
Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #3128 +/- ##
==========================================
- Coverage 0.80% 0.80% -0.01%
==========================================
Files 2541 2541
Lines 323839 323844 +5
Branches 3042 3042
==========================================
Hits 2621 2621
- Misses 319050 319055 +5
Partials 2168 2168 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
There was a problem hiding this comment.
Code Review
The pull request introduces changes to the payment setup, including environment-based configurations for development and production modes, updates to the checkout session creation, and modifications to webhook handling. The changes ensure that the application behaves differently based on the environment it's running in, particularly for payment processing and webhook interactions.
| export const DEV_MODE = process.env.NODE_ENV === 'development'; | ||
| export const PROD_MODE = process.env.NODE_ENV === 'production'; |
There was a problem hiding this comment.
Consider consolidating these environment checks into a single utility function or configuration file to avoid repetition and ensure consistency across the application.
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 0
🧹 Nitpick comments (1)
apps/web/src/app/api/[wsId]/[productId]/payment/route.ts (1)
6-8: Remove unused environment constants.
DEV_MODEandPROD_MODEare defined but never used in this file.-export const DEV_MODE = process.env.NODE_ENV === 'development'; -export const PROD_MODE = process.env.NODE_ENV === 'production';
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (4)
apps/web/src/app/[locale]/(dashboard)/[wsId]/billing/billing-client.tsx(1 hunks)apps/web/src/app/api/[wsId]/[productId]/payment/route.ts(2 hunks)apps/web/src/app/api/webhooks/route.ts(1 hunks)apps/web/src/lib/polar.ts(1 hunks)
🧰 Additional context used
🪛 GitHub Check: codecov/patch
apps/web/src/app/[locale]/(dashboard)/[wsId]/billing/billing-client.tsx
[warning] 5-12: apps/web/src/app/[locale]/(dashboard)/[wsId]/billing/billing-client.tsx#L5-L12
Added lines #L5 - L12 were not covered by tests
apps/web/src/app/api/webhooks/route.ts
[warning] 7-7: apps/web/src/app/api/webhooks/route.ts#L7
Added line #L7 was not covered by tests
apps/web/src/lib/polar.ts
[warning] 5-5: apps/web/src/lib/polar.ts#L5
Added line #L5 was not covered by tests
apps/web/src/app/api/[wsId]/[productId]/payment/route.ts
[warning] 69-70: apps/web/src/app/api/[wsId]/[productId]/payment/route.ts#L69-L70
Added lines #L69 - L70 were not covered by tests
⏰ Context from checks skipped due to timeout of 90000ms (7)
- GitHub Check: Analyze (javascript-typescript)
- GitHub Check: Deploy-Preview
- GitHub Check: Deploy-Preview
- GitHub Check: Verify generated types
- GitHub Check: Deploy-Preview
- GitHub Check: Deploy-Preview
- GitHub Check: Deploy-Preview
🔇 Additional comments (5)
apps/web/src/app/[locale]/(dashboard)/[wsId]/billing/billing-client.tsx (1)
5-5: LGTM! Clean icon library migration.The switch from the local UI library to
lucide-reactfor icons is a straightforward dependency change that maintains the same functionality.apps/web/src/lib/polar.ts (1)
5-5: Verify security implications of public access token usage.The environment-based server selection looks correct for production setup. However, ensure that
NEXT_PUBLIC_POLAR_ACCESS_TOKENbeing public is intentional, as this could expose the token in client-side bundles.Also consider handling other environments explicitly:
- server: process.env.NODE_ENV === 'development' ? 'sandbox' : 'production', + server: process.env.NODE_ENV === 'development' ? 'sandbox' : + process.env.NODE_ENV === 'test' ? 'sandbox' : 'production',apps/web/src/app/api/webhooks/route.ts (1)
7-7: Consistent environment configuration - good alignment.The dynamic server selection matches the pattern in
polar.ts, ensuring consistent environment handling across Polar clients.Same security consideration applies here - verify that using
NEXT_PUBLIC_POLAR_ACCESS_TOKENin server-side code is intentional, as this token will be exposed in client bundles.apps/web/src/app/api/[wsId]/[productId]/payment/route.ts (2)
9-12: Verify the localhost port configuration.The
BASE_URLuses port 7803 for development. Ensure this matches your local development setup, as Next.js typically defaults to port 3000.
69-70: Verify impact of removing externalCustomerId.The
externalCustomerIdfield has been commented out. Ensure this doesn't break customer tracking or subscription management workflows in your payment provider.#!/bin/bash # Search for any references to externalCustomerId to assess impact rg -A 3 -B 3 "externalCustomerId"
Summary by CodeRabbit