unrouted_handler: Change the way to get file size on download #1287
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| StatusCode: http.StatusOK, | ||
| Header: HTTPHeader{ | ||
| "Content-Length": strconv.FormatInt(info.Offset, 10), | ||
| "Content-Length": strconv.FormatInt(info.Size, 10), |
There was a problem hiding this comment.
As far as I understand, this is not entirely correct since the blob might actually not have been completed yet.
I think we should check if we can limit the changes to the azure store.
There was a problem hiding this comment.
Maybe something liks this could work?
- Get commited and uncommited blocks in GetOffset. If there are NO uncommitted blobs then return just those
- Set the offset in
NewUploadof the azure store to 0 and ensure a single empty uncommitted blob is created, if there is aenableVersionedBlobsflag set
There was a problem hiding this comment.
GetFile method is used for handling the GET request and downloading the files. If you try to use this method on the file which is not uploaded completely as you suggest, it would throw ERR_UPLOAD_NOT_FOUND
There was a problem hiding this comment.
Missed that. Just did some testing and you are absolutely right 👍 . Ignore this comment.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use
info.Sizeinstead ofinfo.Offsetwhile setting the headers for http request when downloading a file.Fix for #1286 - tested for Azure