Skip to content

Export /promise types in package.json#exports #125

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from

Conversation

Sheraff
Copy link

@Sheraff Sheraff commented Jun 29, 2024

Following up on #119, this PR proposes that we expose the newer /types/promise.d.ts file through the package.json#exports field, the same way the synchronous interface is exposed.

This PR should allow typescript to access the `/types/promise.d.ts` file.
@noahbrenner
Copy link

I'd love to see this merged. In deno, the types currently work for the synchronous API, but the /promise import is untyped. I would bet that this is the fix.

@penberg
Copy link
Contributor

penberg commented Nov 6, 2024

Argh, missed this PR and did #149... Sorry about that @Sheraff!

@penberg penberg closed this Nov 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants