update to simplify scroll sync behavior #358
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tscanlin
commented
Nov 9, 2024
Comment on lines
-17
to
-22
| if (eTop < cTop + options.tocScrollOffset) { | ||
| toc.scrollTop -= (cTop - eTop) + options.tocScrollOffset | ||
| // Below scroll view | ||
| } else if (eBottom > cBottom - options.tocScrollOffset - SCROLL_LEEWAY) { | ||
| toc.scrollTop += (eBottom - cBottom) + options.tocScrollOffset + (2 * SCROLL_LEEWAY) | ||
| } |
There was a problem hiding this comment.
This was not always ideal and felt buggy since it would just barely keep the items in view.
tscanlin
commented
Nov 9, 2024
Comment on lines
+12
to
+13
| const scrollAmount = eTop - options.tocScrollOffset | ||
| toc.scrollTop = scrollAmount > 0 ? scrollAmount : 0 |
There was a problem hiding this comment.
This new way is more similar to how Stripe does it:
https://docs.stripe.com/api
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
update to simplify scroll sync behavior to be simpler and easier to follow. This should result in things feeling like they are jumping around less in long TOC's. I think because this only affects very long TOCs and since it seems like an improvement that this should be a pretty low risk change.
new way
previous way
