Skip to content

feat: Support verifying govcloud aws sessions #4087

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 4 commits into
base: main
Choose a base branch
from
Open
Changes from 2 commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
37 changes: 31 additions & 6 deletions pkg/detectors/aws/session_keys/sessionkey.go
Original file line number Diff line number Diff line change
Expand Up @@ -161,14 +161,33 @@ func (s scanner) ShouldCleanResultsIrrespectiveOfConfiguration() bool {
}

const (
method = "GET"
service = "sts"
host = "sts.amazonaws.com"
region = "us-east-1"
endpoint = "https://sts.amazonaws.com"
method = "GET"
service = "sts"
regionCommercial = "us-east-1"
hostCommercial = "sts.amazonaws.com"
regionGovCloud = "us-gov-east-1"
hostGovCloud = "sts." + regionGovCloud + ".amazonaws.com"
)

func (s scanner) verifyMatch(ctx context.Context, resIDMatch, resSecretMatch string, resSessionMatch string, retryOn403 bool) (bool, map[string]string, error) {
func (s scanner) verifyMatch(ctx context.Context, resIDMatch, resSecretMatch, resSessionMatch string, retryOn403 bool) (bool, map[string]string, error) {
ok, data, err := s.attemptVerifyMatch(ctx, resIDMatch, resSecretMatch, resSessionMatch, retryOn403, regionCommercial, hostCommercial)
if err == nil && ok {
return true, data, nil
}

ok, data, err = s.attemptVerifyMatch(ctx, resIDMatch, resSecretMatch, resSessionMatch, retryOn403, regionGovCloud, hostGovCloud)
if err == nil && ok {
return true, data, nil
}

return false, nil, err
}

func (s scanner) attemptVerifyMatch(ctx context.Context, resIDMatch, resSecretMatch, resSessionMatch string, retryOn403 bool, region, host string) (bool, map[string]string, error) {
const method = "GET"
const service = "sts"
endpoint := "https://" + host

// REQUEST VALUES.
now := time.Now().UTC()
datestamp := now.Format("20060102")
Expand Down Expand Up @@ -238,11 +257,17 @@ func (s scanner) verifyMatch(ctx context.Context, resIDMatch, resSecretMatch str
return false, nil, err
}

accountType := "commercial"
if strings.Contains(identityInfo.GetCallerIdentityResponse.GetCallerIdentityResult.Arn, "us-gov") {
accountType = "gov-cloud"
}

extraData := map[string]string{
"rotation_guide": "https://howtorotate.com/docs/tutorials/aws/",
"account": identityInfo.GetCallerIdentityResponse.GetCallerIdentityResult.Account,
"user_id": identityInfo.GetCallerIdentityResponse.GetCallerIdentityResult.UserID,
"arn": identityInfo.GetCallerIdentityResponse.GetCallerIdentityResult.Arn,
"type": accountType,
}
return true, extraData, nil
} else if res.StatusCode == 403 {
Expand Down